* [PATCH proxmox 1/1] installer-types: add missing properties to filesystem api schema
@ 2026-05-28 9:25 Stefan Hanreich
2026-05-28 9:45 ` Samuel Rufinatscha
2026-05-28 11:00 ` applied: " Thomas Lamprecht
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Hanreich @ 2026-05-28 9:25 UTC (permalink / raw)
To: pdm-devel
Otherwise, setting those properties causes issues on deserialization,
since they're deserialized as additional properties (= String), which
causes a '400 Bad Request' when trying to retrieve the answers via the
PDM UI or the automated installer ISO.
Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
proxmox-installer-types/src/answer.rs | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/proxmox-installer-types/src/answer.rs b/proxmox-installer-types/src/answer.rs
index 9c6317ae..27abd9ae 100644
--- a/proxmox-installer-types/src/answer.rs
+++ b/proxmox-installer-types/src/answer.rs
@@ -508,6 +508,13 @@ impl ApiType for FilesystemOptions {
const API_SCHEMA: Schema = ObjectSchema::new(
"Filesystem-specific options to set on the root disk.",
&[
+ (
+ "arc_max",
+ true,
+ &IntegerSchema::new("Maximum ARC size that ZFS should use, in MiB")
+ .minimum(64)
+ .schema(),
+ ),
(
"ashift",
true,
@@ -517,6 +524,15 @@ impl ApiType for FilesystemOptions {
.default(12)
.schema(),
),
+ (
+ "copies",
+ true,
+ &IntegerSchema::new("`copies` value to create the zpool with.")
+ .minimum(1)
+ .maximum(3)
+ .default(1)
+ .schema(),
+ ),
("filesystem", false, &Filesystem::API_SCHEMA),
(
"hdsize",
@@ -548,6 +564,15 @@ impl ApiType for FilesystemOptions {
.minimum(0.)
.schema(),
),
+ (
+ "minfree",
+ true,
+ &NumberSchema::new(
+ "Minimum amount of free space that should be left in the LVM volume group.",
+ )
+ .minimum(0.)
+ .schema(),
+ ),
(
"swapsize",
true,
--
2.47.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH proxmox 1/1] installer-types: add missing properties to filesystem api schema
2026-05-28 9:25 [PATCH proxmox 1/1] installer-types: add missing properties to filesystem api schema Stefan Hanreich
@ 2026-05-28 9:45 ` Samuel Rufinatscha
2026-05-28 11:00 ` applied: " Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Samuel Rufinatscha @ 2026-05-28 9:45 UTC (permalink / raw)
To: Stefan Hanreich, pdm-devel
On 5/28/26 11:25 AM, Stefan Hanreich wrote:
> Otherwise, setting those properties causes issues on deserialization,
> since they're deserialized as additional properties (= String), which
> causes a '400 Bad Request' when trying to retrieve the answers via the
> PDM UI or the automated installer ISO.
>
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
> proxmox-installer-types/src/answer.rs | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/proxmox-installer-types/src/answer.rs b/proxmox-installer-types/src/answer.rs
> index 9c6317ae..27abd9ae 100644
> --- a/proxmox-installer-types/src/answer.rs
> +++ b/proxmox-installer-types/src/answer.rs
> @@ -508,6 +508,13 @@ impl ApiType for FilesystemOptions {
> const API_SCHEMA: Schema = ObjectSchema::new(
> "Filesystem-specific options to set on the root disk.",
> &[
> + (
> + "arc_max",
> + true,
> + &IntegerSchema::new("Maximum ARC size that ZFS should use, in MiB")
> + .minimum(64)
> + .schema(),
> + ),
> (
> "ashift",
> true,
> @@ -517,6 +524,15 @@ impl ApiType for FilesystemOptions {
> .default(12)
> .schema(),
> ),
> + (
> + "copies",
> + true,
> + &IntegerSchema::new("`copies` value to create the zpool with.")
> + .minimum(1)
> + .maximum(3)
> + .default(1)
> + .schema(),
> + ),
> ("filesystem", false, &Filesystem::API_SCHEMA),
> (
> "hdsize",
> @@ -548,6 +564,15 @@ impl ApiType for FilesystemOptions {
> .minimum(0.)
> .schema(),
> ),
> + (
> + "minfree",
> + true,
> + &NumberSchema::new(
> + "Minimum amount of free space that should be left in the LVM volume group.",
> + )
> + .minimum(0.)
> + .schema(),
> + ),
> (
> "swapsize",
> true,
Tested - the patch fixes the issue.
Thanks for this super fast patch!
Tested-by: Samuel Rufinatscha <s.rufinatscha@proxmox.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* applied: [PATCH proxmox 1/1] installer-types: add missing properties to filesystem api schema
2026-05-28 9:25 [PATCH proxmox 1/1] installer-types: add missing properties to filesystem api schema Stefan Hanreich
2026-05-28 9:45 ` Samuel Rufinatscha
@ 2026-05-28 11:00 ` Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2026-05-28 11:00 UTC (permalink / raw)
To: pdm-devel, Stefan Hanreich
On Thu, 28 May 2026 11:25:14 +0200, Stefan Hanreich wrote:
> Otherwise, setting those properties causes issues on deserialization,
> since they're deserialized as additional properties (= String), which
> causes a '400 Bad Request' when trying to retrieve the answers via the
> PDM UI or the automated installer ISO.
Applied, thanks!
[1/1] installer-types: add missing properties to filesystem api schema
commit: 391bf26830b179aedd81eea5727e261efc6ab77d
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-05-28 11:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-28 9:25 [PATCH proxmox 1/1] installer-types: add missing properties to filesystem api schema Stefan Hanreich
2026-05-28 9:45 ` Samuel Rufinatscha
2026-05-28 11:00 ` applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.