From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E5DC41FF13C for ; Thu, 28 May 2026 11:26:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 86B5D1021A; Thu, 28 May 2026 11:25:59 +0200 (CEST) From: Stefan Hanreich To: pdm-devel@lists.proxmox.com Subject: [PATCH proxmox 1/1] installer-types: add missing properties to filesystem api schema Date: Thu, 28 May 2026 11:25:14 +0200 Message-ID: <20260528092516.103885-1-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779960297221 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.599 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [answer.rs] Message-ID-Hash: I7CIWWUZZJ52TGPURKHMBNW4JQJ7XPI6 X-Message-ID-Hash: I7CIWWUZZJ52TGPURKHMBNW4JQJ7XPI6 X-MailFrom: s.hanreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Otherwise, setting those properties causes issues on deserialization, since they're deserialized as additional properties (= String), which causes a '400 Bad Request' when trying to retrieve the answers via the PDM UI or the automated installer ISO. Signed-off-by: Stefan Hanreich --- proxmox-installer-types/src/answer.rs | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/proxmox-installer-types/src/answer.rs b/proxmox-installer-types/src/answer.rs index 9c6317ae..27abd9ae 100644 --- a/proxmox-installer-types/src/answer.rs +++ b/proxmox-installer-types/src/answer.rs @@ -508,6 +508,13 @@ impl ApiType for FilesystemOptions { const API_SCHEMA: Schema = ObjectSchema::new( "Filesystem-specific options to set on the root disk.", &[ + ( + "arc_max", + true, + &IntegerSchema::new("Maximum ARC size that ZFS should use, in MiB") + .minimum(64) + .schema(), + ), ( "ashift", true, @@ -517,6 +524,15 @@ impl ApiType for FilesystemOptions { .default(12) .schema(), ), + ( + "copies", + true, + &IntegerSchema::new("`copies` value to create the zpool with.") + .minimum(1) + .maximum(3) + .default(1) + .schema(), + ), ("filesystem", false, &Filesystem::API_SCHEMA), ( "hdsize", @@ -548,6 +564,15 @@ impl ApiType for FilesystemOptions { .minimum(0.) .schema(), ), + ( + "minfree", + true, + &NumberSchema::new( + "Minimum amount of free space that should be left in the LVM volume group.", + ) + .minimum(0.) + .schema(), + ), ( "swapsize", true, -- 2.47.3