all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Elias Huhsovitz <e.huhsovitz@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH qemu-server-rs v4 1/4] cpu: add pve-qemu-server-cpu crate for vCPU binding
Date: Thu, 19 Nov 2026 11:06:28 +0100	[thread overview]
Message-ID: <d9ae900d-6754-4212-a362-5f5509d97472@proxmox.com> (raw)
In-Reply-To: <DMZ2OMG2IIYY.2JCJ4KQ3VW8QQ@proxmox.com>



On 11/19/26 10:16 AM, Elias Huhsovitz wrote:
> On Tue Nov 17, 2026 at 5:28 PM CET, Dominik Csapak wrote:
[snip]
>>
>> together with the qemu-server patch 4/4 this now skips the
>> affinity when cpu-binding-mode is 'none', since the
>> qemu-server check skips the taskset and here we return nothing.
>>
>> we should either return the affinity map for all cores here
>> or let the taskset run throuh in qemu-server
>>
>> (actually we could let the taskset limit the threads anyway, this
>> code here can only further restrict it AFAICS)
>>
> 
> Good catch! I would prefer to just have something like
> 
> if (cpu-binding-mode == 'none') {
> 	// init qemu using taskset
> }
> 
> But I am thinking of simply removing the 'none' state alltogether, as it
> seems redundant.
> 

i'd probably keep the 'none' value and mark it as default
that way the docs are automatically a bit clearer
and we could move the whole taskset call in here


that's what i meant with th code snippet on the other patch

we just have to call this always, and if the mode is not set
use 'none' by default.






  reply	other threads:[~2026-11-19 10:06 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11 15:20 [RFC proxmox-perl-rs/qemu-server/qemu-server-rs v4 0/4] vCPU binding for qemu guests Elias Huhsovitz
2026-11-11 15:20 ` [PATCH qemu-server-rs v4 1/4] cpu: add pve-qemu-server-cpu crate for vCPU binding Elias Huhsovitz
2026-11-17 16:28   ` Dominik Csapak
2026-11-19  9:16     ` Elias Huhsovitz
2026-11-19 10:06       ` Dominik Csapak [this message]
2026-11-17 17:20   ` Thomas Lamprecht
2026-11-18  7:47     ` Dominik Csapak
2026-11-18  8:32       ` Thomas Lamprecht
2026-11-18 10:14         ` Fiona Ebner
2026-11-18 11:17           ` Elias Huhsovitz
2026-11-18 11:44             ` Thomas Lamprecht
2026-11-18 13:05               ` Elias Huhsovitz
2026-11-11 15:20 ` [PATCH proxmox-perl-rs v4 2/4] pve: cpu: add binding for pve-qemu-server-cpu crate Elias Huhsovitz
2026-11-17 16:37   ` Dominik Csapak
2026-11-11 15:20 ` [PATCH qemu-server v4 3/4] helpers: return integer values for parse_number_sets Elias Huhsovitz
2026-11-17 16:39   ` Dominik Csapak
2026-11-11 15:20 ` [PATCH qemu-server v4 4/4] cpu: add cpu binding Elias Huhsovitz
2026-11-17 16:36   ` Dominik Csapak
2026-11-19  9:35     ` Elias Huhsovitz
2026-11-19 10:07       ` Dominik Csapak
2026-11-19 13:16         ` Elias Huhsovitz
2026-11-19 17:08           ` Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9ae900d-6754-4212-a362-5f5509d97472@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=e.huhsovitz@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal