From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 023921FF0DF for ; Thu, 19 Nov 2026 11:06:33 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 35873216BB; Thu, 19 Nov 2026 11:06:32 +0100 (CET) Message-ID: Date: Thu, 19 Nov 2026 11:06:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH qemu-server-rs v4 1/4] cpu: add pve-qemu-server-cpu crate for vCPU binding To: Elias Huhsovitz , pve-devel@lists.proxmox.com References: <20261111152027.260117-1-e.huhsovitz@proxmox.com> <20261111152027.260117-2-e.huhsovitz@proxmox.com> <88f12126-6022-47cb-b1b6-ab1895736cff@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795082788769 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.276 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: FMBTDUPW4UXLVC7XOLDPKL5LQSTFGPZS X-Message-ID-Hash: FMBTDUPW4UXLVC7XOLDPKL5LQSTFGPZS X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 11/19/26 10:16 AM, Elias Huhsovitz wrote: > On Tue Nov 17, 2026 at 5:28 PM CET, Dominik Csapak wrote: [snip] >> >> together with the qemu-server patch 4/4 this now skips the >> affinity when cpu-binding-mode is 'none', since the >> qemu-server check skips the taskset and here we return nothing. >> >> we should either return the affinity map for all cores here >> or let the taskset run throuh in qemu-server >> >> (actually we could let the taskset limit the threads anyway, this >> code here can only further restrict it AFAICS) >> > > Good catch! I would prefer to just have something like > > if (cpu-binding-mode == 'none') { > // init qemu using taskset > } > > But I am thinking of simply removing the 'none' state alltogether, as it > seems redundant. > i'd probably keep the 'none' value and mark it as default that way the docs are automatically a bit clearer and we could move the whole taskset call in here that's what i meant with th code snippet on the other patch we just have to call this always, and if the mode is not set use 'none' by default.