all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>,
	Elias Huhsovitz <e.huhsovitz@proxmox.com>,
	pve-devel@lists.proxmox.com
Cc: Wolfgang Bumiller <w.bumiller@proxmox.com>
Subject: Re: [PATCH qemu-server-rs v4 1/4] cpu: add pve-qemu-server-cpu crate for vCPU binding
Date: Wed, 18 Nov 2026 09:32:42 +0100	[thread overview]
Message-ID: <7d82cab7-5941-42cf-a610-02e8cdb12bda@proxmox.com> (raw)
In-Reply-To: <a287cbf9-b4a2-4eb8-9b2c-9776bd278c77@proxmox.com>

Am 18.11.26 um 08:48 schrieb Dominik Csapak:
> On 11/17/26 6:20 PM, Thomas Lamprecht wrote:
>> Am 11.11.26 um 16:22 schrieb Elias Huhsovitz:
>> Any rationale for why using rust here would be great, it can be fine
>> but it's not exactly cheap, so some sort of justification might be
>> nice.
> 
> This is (in part) my doing:
> 
> When talking off list with elias regarding his first versions,
> the question perl or rust came up and i said that i'm in favor
> of using rust vs perl, at least for new and self-contained
> parts.
> 
> I chose rust for the pci stuff because the type system really
> helped me out there, and if we have a place to put qemu-server
> rust code, i though new stuff could go in there.

As said it can be fine, just needs some basic justification and ideally
maintenance cost analysis – gut feeling can be fine too. IME whole
subsystems can be great, especially if they can be reused in PBS or PDM
or so. Smaller parsers and simple logic needs a bit more care, as they
have a relative high amount of churn required for rolling out updates.
I ran into this in the SAN series, where Dietmar wished for it the
parser to be in rust and I figured why not, but I had basically zero
benefit there and just two more repos and packages involved, making
testing significantly harder too (got even a ty from an interested
tester for the v4 that was then perl only).

For smaller crates I think a good heuristic is judging how frequent
it will get updates. If its basically done at initial addition besides
some bug fix or so then its fine. If its really complex and/or gets
reused elsewhere its most of the time fine too. Otherwise I'd question
it a bit more deeply. Nowadays good inter-language translations are
relatively cheap and most logic and test maturity can be migrated
there too. For qemu-server I also got some prototypes in how a rust
future could look like, so we could do a bigger push here after the
releases (as then it would be feasible for next minor release, allowing
us to share more between the next forky based major release and the
then oldstable trixie releases next year).

Here I do not want to block this as is, mostly saying it for the
near future as – to exaggerate - sprinkling lots of micro crates all
over the place eats up the rust benefit _very_ fast and will weight
us down while not really bringing us significantly closer to a
fully-rust code base in the current phase. Bigger migrations, whole
subsystems or shared ones are almost always fine.

>>>       "pve-qemu-server-pci"
>>>   ]
>>
>> applies to yours and Dominiks [pci series]: I'd rather not propagate
>> the naming oddity of including "server" here to rust, when we finally
>> got a chance of dropping some legacy decisions cheaply.
>> I.e., lets do at least a s/server// please, server does made really
>> sense in how "qemu-server" gets used nowadays.
> 
> sure of course, i just started with something and didn't get feedback
> on the naming (until now) so that's fine by me
> 
> (i feared 'pve-qemu-rs' is too close to 'pve-qemu-kvm' or 'pve-qemu',
> but if it's fine for you i'll change it)

FWIW, pve-vm is fine too for me. But here I'd appreciate some input
from the people working most in this subsystems.

>> And another thing that would be easy to do now: put these into the
>> qemu-server repo directly and generate a perlmod backed library
>> there. Each change, addition would then avoid going through an
>> extra repo and packaging, and qemu management is a big, important
>> and well enough scoped use case to justify a dedicated lib here (which
>> I'd not do for all repos).
> 
> sure, started fresh to not run into merge conflicts and basically
> starting from a clean slate regarding build system
> (which made my life easier). I'll send a new version of my
> series integrating it into qemu-server repo

I'd not rush this to quickly now (just to avoid needless work), as
mentioned already initially, maintainers should have a say here and
asking them directly on such core naming is more fruitful than hoping
it gets noticed when seeing a series fly by on the list.





  reply	other threads:[~2026-11-18  8:32 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11 15:20 [RFC proxmox-perl-rs/qemu-server/qemu-server-rs v4 0/4] vCPU binding for qemu guests Elias Huhsovitz
2026-11-11 15:20 ` [PATCH qemu-server-rs v4 1/4] cpu: add pve-qemu-server-cpu crate for vCPU binding Elias Huhsovitz
2026-11-17 16:28   ` Dominik Csapak
2026-11-19  9:16     ` Elias Huhsovitz
2026-11-19 10:06       ` Dominik Csapak
2026-11-17 17:20   ` Thomas Lamprecht
2026-11-18  7:47     ` Dominik Csapak
2026-11-18  8:32       ` Thomas Lamprecht [this message]
2026-11-18 10:14         ` Fiona Ebner
2026-11-18 11:17           ` Elias Huhsovitz
2026-11-18 11:44             ` Thomas Lamprecht
2026-11-18 13:05               ` Elias Huhsovitz
2026-11-11 15:20 ` [PATCH proxmox-perl-rs v4 2/4] pve: cpu: add binding for pve-qemu-server-cpu crate Elias Huhsovitz
2026-11-17 16:37   ` Dominik Csapak
2026-11-11 15:20 ` [PATCH qemu-server v4 3/4] helpers: return integer values for parse_number_sets Elias Huhsovitz
2026-11-17 16:39   ` Dominik Csapak
2026-11-11 15:20 ` [PATCH qemu-server v4 4/4] cpu: add cpu binding Elias Huhsovitz
2026-11-17 16:36   ` Dominik Csapak
2026-11-19  9:35     ` Elias Huhsovitz
2026-11-19 10:07       ` Dominik Csapak
2026-11-19 13:16         ` Elias Huhsovitz
2026-11-19 17:08           ` Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7d82cab7-5941-42cf-a610-02e8cdb12bda@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=e.huhsovitz@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=w.bumiller@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal