From: Fiona Ebner <f.ebner@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH qemu-server v3 3/3] fix #7119: qm cleanup: wait for process exiting for up to 30 seconds
Date: Wed, 13 May 2026 17:19:31 +0200 [thread overview]
Message-ID: <d25c564a-827b-4ef3-9704-f40e64cffd50@proxmox.com> (raw)
In-Reply-To: <6e5aaa63-60ce-4d8c-806d-b13f68327e8e@proxmox.com>
Am 13.05.26 um 5:14 PM schrieb Fiona Ebner:
> Am 26.02.26 um 3:08 PM schrieb Dominik Csapak:
>> + die "vm still running after timeout - aborting cleanup\n" if $pid;
Oh, and I would reformulate this to something like
"aborting cleanup, because VM is still running after $timeout seconds\n"
to mention which operation failed up front.
next prev parent reply other threads:[~2026-05-13 15:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 13:51 [PATCH qemu-server v3 0/3] improve guest cleanup handling Dominik Csapak
2026-02-26 13:52 ` [PATCH qemu-server v3 1/3] cleanup: refactor to make cleanup flow consistent Dominik Csapak
2026-02-27 11:44 ` Dominik Csapak
2026-05-13 15:02 ` Fiona Ebner
2026-02-26 13:52 ` [PATCH qemu-server v3 2/3] qm cleanup: die early when encountering a running stop mode backup Dominik Csapak
2026-05-13 15:08 ` Fiona Ebner
2026-02-26 13:52 ` [PATCH qemu-server v3 3/3] fix #7119: qm cleanup: wait for process exiting for up to 30 seconds Dominik Csapak
2026-04-15 7:14 ` Benjamin McGuire
2026-05-13 15:14 ` Fiona Ebner
2026-05-13 15:19 ` Fiona Ebner [this message]
2026-05-15 9:52 ` Dominik Csapak
2026-05-15 10:12 ` Fiona Ebner
2026-04-14 11:42 ` [PATCH qemu-server v3 0/3] improve guest cleanup handling Dominik Csapak
2026-05-15 10:09 ` superseded: " Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d25c564a-827b-4ef3-9704-f40e64cffd50@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.