From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: superseded: [PATCH qemu-server v3 0/3] improve guest cleanup handling
Date: Fri, 15 May 2026 12:09:41 +0200 [thread overview]
Message-ID: <2f03326d-eb85-4d05-83f4-32ffd10c3df2@proxmox.com> (raw)
In-Reply-To: <20260226140752.1792378-1-d.csapak@proxmox.com>
superseded by v4:
https://lore.proxmox.com/pve-devel/20260515100842.1980636-1-d.csapak@proxmox.com/T/#t
On 2/26/26 3:07 PM, Dominik Csapak wrote:
> this is a combination of my previous patches[0][1] (v3 because [0] was
> already v2)
>
> First we make the cleanup handling more consistent (1/3)
> then we check explicitely for the backup lock to improve the error
> message for stop backup mode (2/3)
> and then we fix #7119 by waiting up to 30s for a possibly still running
> guest to stop (e.g. this can occur when using usb passthrouh) (3/3)
>
> changes from v2/RFC:
> * use 'vm_running_locally' for getting the pid
> * improve error messages
> * use a 'use_old_cleanup' flag that will be auto-removed by a reboot
> to signal if we can use the new cleanup logic or the old
>
> 0: https://lore.proxmox.com/pve-devel/20260210111612.2017883-1-d.csapak@proxmox.com/
> 1: https://lore.proxmox.com/pve-devel/20260223105542.1525232-1-d.csapak@proxmox.com/
>
> Dominik Csapak (3):
> cleanup: refactor to make cleanup flow consistent
> qm cleanup: die early when encountering a running stop mode backup
> fix #7119: qm cleanup: wait for process exiting for up to 30 seconds
>
> debian/preinst | 16 +++++++++++++++
> src/PVE/CLI/qm.pm | 35 +++++++++++++++++++++++++++-----
> src/PVE/QemuServer.pm | 14 +++++++++++++
> src/PVE/QemuServer/RunState.pm | 28 +++++++++++++++++++++++++
> src/test/MigrationTest/QmMock.pm | 16 +++++++++++++++
> 5 files changed, 104 insertions(+), 5 deletions(-)
> create mode 100755 debian/preinst
>
prev parent reply other threads:[~2026-05-15 10:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 13:51 [PATCH qemu-server v3 0/3] improve guest cleanup handling Dominik Csapak
2026-02-26 13:52 ` [PATCH qemu-server v3 1/3] cleanup: refactor to make cleanup flow consistent Dominik Csapak
2026-02-27 11:44 ` Dominik Csapak
2026-05-13 15:02 ` Fiona Ebner
2026-02-26 13:52 ` [PATCH qemu-server v3 2/3] qm cleanup: die early when encountering a running stop mode backup Dominik Csapak
2026-05-13 15:08 ` Fiona Ebner
2026-02-26 13:52 ` [PATCH qemu-server v3 3/3] fix #7119: qm cleanup: wait for process exiting for up to 30 seconds Dominik Csapak
2026-04-15 7:14 ` Benjamin McGuire
2026-05-13 15:14 ` Fiona Ebner
2026-05-13 15:19 ` Fiona Ebner
2026-05-15 9:52 ` Dominik Csapak
2026-05-15 10:12 ` Fiona Ebner
2026-04-14 11:42 ` [PATCH qemu-server v3 0/3] improve guest cleanup handling Dominik Csapak
2026-05-15 10:09 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f03326d-eb85-4d05-83f4-32ffd10c3df2@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.