From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 426591FF13A
	for <inbox@lore.proxmox.com>; Wed, 13 May 2026 17:19:37 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 2CF5715E41;
	Wed, 13 May 2026 17:19:35 +0200 (CEST)
Message-ID: <d25c564a-827b-4ef3-9704-f40e64cffd50@proxmox.com>
Date: Wed, 13 May 2026 17:19:31 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH qemu-server v3 3/3] fix #7119: qm cleanup: wait for
 process exiting for up to 30 seconds
From: Fiona Ebner <f.ebner@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>, pve-devel@lists.proxmox.com
References: <20260226140752.1792378-1-d.csapak@proxmox.com>
 <20260226140752.1792378-4-d.csapak@proxmox.com>
 <6e5aaa63-60ce-4d8c-806d-b13f68327e8e@proxmox.com>
Content-Language: en-US
In-Reply-To: <6e5aaa63-60ce-4d8c-806d-b13f68327e8e@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1778685568175
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.009 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: USC767PWMWFZMTT5TDODJLURBMUSJNI4
X-Message-ID-Hash: USC767PWMWFZMTT5TDODJLURBMUSJNI4
X-MailFrom: f.ebner@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

Am 13.05.26 um 5:14 PM schrieb Fiona Ebner:
> Am 26.02.26 um 3:08 PM schrieb Dominik Csapak:
>> +                die "vm still running after timeout - aborting cleanup\n" if $pid;

Oh, and I would reformulate this to something like
"aborting cleanup, because VM is still running after $timeout seconds\n"
to mention which operation failed up front.