From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>,
pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-backup] EncryptionKeysView: Fix API2 error alert messages
Date: Wed, 29 Apr 2026 11:57:44 +0200 [thread overview]
Message-ID: <c58317b7-06bd-42ac-ba3c-674619ff89b8@proxmox.com> (raw)
In-Reply-To: <20260428150950.50795-1-a.bied-charreton@proxmox.com>
Code change is fine, but the metadata needs polish before this can go in,
it's only the subject that should improve though:
* Subject prefix should be the product area, not a JS class name. For
this view we use `ui: encryption keys: ...`, see e.g. ffe55e23e,
67235b5fb. Lowercase, two-level path, separated by colons.
* Lowercase imperative after the colon: "Fix" -> "fix".
* The text after the prefix should describe what visibly changes for
the user, not the mechanism. "Fix API2 error alert messages" hides
the symptom; something like
ui: encryption keys: show actual error text in API alerts instead of empty popup
reads on its own in `git log` and tells a future git bisect(or)
and changelog writers what this really changed without having
to look at the full commit message or even the code changes.
See the proxmox commit-message conventions on the dev wiki and
`git log --oneline www/` for examples in this tree.
next prev parent reply other threads:[~2026-04-29 9:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 15:09 [PATCH proxmox-backup] EncryptionKeysView: Fix API2 error alert messages Arthur Bied-Charreton
2026-04-29 9:57 ` Daniel Kral
2026-04-29 9:57 ` Thomas Lamprecht [this message]
2026-04-29 9:59 ` Christian Ebner
2026-04-29 10:05 ` Arthur Bied-Charreton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c58317b7-06bd-42ac-ba3c-674619ff89b8@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=a.bied-charreton@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.