From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-backup] EncryptionKeysView: Fix API2 error alert messages
Date: Wed, 29 Apr 2026 11:59:42 +0200 [thread overview]
Message-ID: <a2d4a745-e0ac-4a36-b22c-d4eceba58e52@proxmox.com> (raw)
In-Reply-To: <20260428150950.50795-1-a.bied-charreton@proxmox.com>
On 4/28/26 5:08 PM, Arthur Bied-Charreton wrote:
> The errors returned by the encryption-keys and tape-encryption-keys
> endpoints are not plain strings, so the alerts displayed on API2 errors
> like failed permission checks end up being empty and therefore not very
> helpful.
>
> Extract the error messages to display them correctly in alerts.
>
> Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
> ---
Thanks for the patch, definitely fine as stop-gap for now. But I think I
have to improve the error handling here in general. This should probably
include setting the error mask if neither permissions for tape or sync
keys are given to the user, and less invasive show the missing
permissions for other combinations.
next prev parent reply other threads:[~2026-04-29 10:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 15:09 [PATCH proxmox-backup] EncryptionKeysView: Fix API2 error alert messages Arthur Bied-Charreton
2026-04-29 9:57 ` Daniel Kral
2026-04-29 9:57 ` Thomas Lamprecht
2026-04-29 9:59 ` Christian Ebner [this message]
2026-04-29 10:05 ` Arthur Bied-Charreton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2d4a745-e0ac-4a36-b22c-d4eceba58e52@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.