all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Daniel Kral" <d.kral@proxmox.com>
To: "Arthur Bied-Charreton" <a.bied-charreton@proxmox.com>,
	<pbs-devel@lists.proxmox.com>
Subject: Re: [PATCH proxmox-backup] EncryptionKeysView: Fix API2 error alert messages
Date: Wed, 29 Apr 2026 11:57:29 +0200	[thread overview]
Message-ID: <DI5JSO4F30FV.3EPAGLDTM8HAJ@proxmox.com> (raw)
In-Reply-To: <20260428150950.50795-1-a.bied-charreton@proxmox.com>

On Tue Apr 28, 2026 at 5:09 PM CEST, Arthur Bied-Charreton wrote:
> The errors returned by the encryption-keys and tape-encryption-keys
> endpoints are not plain strings, so the alerts displayed on API2 errors
> like failed permission checks end up being empty and therefore not very
> helpful.
>
> Extract the error messages to display them correctly in alerts.
>
> Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
> ---
>  www/config/EncryptionKeysView.js | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/www/config/EncryptionKeysView.js b/www/config/EncryptionKeysView.js
> index 0f9367c7..bb327814 100644
> --- a/www/config/EncryptionKeysView.js
> +++ b/www/config/EncryptionKeysView.js
> @@ -168,7 +168,7 @@ Ext.define('PBS.config.EncryptionKeysView', {
>                      });
>                  }
>              } catch (error) {
> -                Ext.Msg.alert(gettext('Error'), error);
> +                Ext.Msg.alert(gettext('Error'), error.result?.message || gettext('Unknown error'));
>              }
>  
>              try {
> @@ -181,7 +181,7 @@ Ext.define('PBS.config.EncryptionKeysView', {
>                      });
>                  }
>              } catch (error) {
> -                Ext.Msg.alert(gettext('Error'), error);
> +                Ext.Msg.alert(gettext('Error'), error.result?.message || gettext('Unknown error'));
>              }
>  
>              let store = view.getStore().rstore;

Usually we use `error.htmlStatus` for the error message, but this should
be fine here as well.

This fixes the issue for me as well, so consider as:

Reviewed-by: Daniel Kral <d.kral@proxmox.com>
Tested-by: Daniel Kral <d.kral@proxmox.com>




  reply	other threads:[~2026-04-29  9:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-28 15:09 [PATCH proxmox-backup] EncryptionKeysView: Fix API2 error alert messages Arthur Bied-Charreton
2026-04-29  9:57 ` Daniel Kral [this message]
2026-04-29  9:57 ` Thomas Lamprecht
2026-04-29  9:59 ` Christian Ebner
2026-04-29 10:05 ` Arthur Bied-Charreton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DI5JSO4F30FV.3EPAGLDTM8HAJ@proxmox.com \
    --to=d.kral@proxmox.com \
    --cc=a.bied-charreton@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal