all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH proxmox-backup] docs: notifications: fix broken calendar match examples
@ 2026-07-23 11:45 Arthur Bied-Charreton
  2026-07-23 22:00 ` Thomas Lamprecht
  0 siblings, 1 reply; 3+ messages in thread
From: Arthur Bied-Charreton @ 2026-07-23 11:45 UTC (permalink / raw)
  To: pbs-devel

The calendar matcher examples showed weekday ranges as start-end. The
correct syntax is start..end - these example configs do not parse.

Update the examples to the correct a..b range syntax.

Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
---
 docs/notifications.rst | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/docs/notifications.rst b/docs/notifications.rst
index 440c700a4..7d6517dd7 100644
--- a/docs/notifications.rst
+++ b/docs/notifications.rst
@@ -217,8 +217,8 @@ Examples:
 
 * ``match-calendar 8-12``
 * ``match-calendar 8:00-15:30``
-* ``match-calendar mon-fri 9:00-17:00``
-* ``match-calendar sun,tue-wed,fri 9-17``
+* ``match-calendar mon..fri 9:00-17:00``
+* ``match-calendar sun,tue..wed,fri 9-17``
 
 Field Matching Rules
 ^^^^^^^^^^^^^^^^^^^^
@@ -417,4 +417,3 @@ Counter Threshold    Description and Usage
 ``s3-download``      Amount of bytes downloaded from the S3 endpoint,
                      independent of request method.
 ==================== ==========================================================
-
-- 
2.47.3




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH proxmox-backup] docs: notifications: fix broken calendar match examples
  2026-07-23 11:45 [PATCH proxmox-backup] docs: notifications: fix broken calendar match examples Arthur Bied-Charreton
@ 2026-07-23 22:00 ` Thomas Lamprecht
  2026-07-24  5:21   ` Arthur Bied-Charreton
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Lamprecht @ 2026-07-23 22:00 UTC (permalink / raw)
  To: Arthur Bied-Charreton, pbs-devel

Am 23.07.26 um 13:45 schrieb Arthur Bied-Charreton:
> The calendar matcher examples showed weekday ranges as start-end. The
> correct syntax is start..end - these example configs do not parse.
> 
> Update the examples to the correct a..b range syntax.
> 
> Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
> ---
>  docs/notifications.rst | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/docs/notifications.rst b/docs/notifications.rst
> index 440c700a4..7d6517dd7 100644
> --- a/docs/notifications.rst
> +++ b/docs/notifications.rst
> @@ -217,8 +217,8 @@ Examples:
>  
>  * ``match-calendar 8-12``

Shouldn't above also change? or is that hours? These examples here
would IMO do very well with actually explaining what each means, it's
not exactly clear as it stands. A reference to the calendar events
appendix at _calendar-event-scheduling would already help a lot and
might we warranted either way, if this here is really using that format.

>  * ``match-calendar 8:00-15:30``
> -* ``match-calendar mon-fri 9:00-17:00``

FWIW; systemd-analyze calendar "mon-fri" works, but it does normalize
it to mon..fri

> -* ``match-calendar sun,tue-wed,fri 9-17``
> +* ``match-calendar mon..fri 9:00-17:00``
> +* ``match-calendar sun,tue..wed,fri 9-17``
>  
>  Field Matching Rules
>  ^^^^^^^^^^^^^^^^^^^^
> @@ -417,4 +417,3 @@ Counter Threshold    Description and Usage
>  ``s3-download``      Amount of bytes downloaded from the S3 endpoint,
>                       independent of request method.
>  ==================== ==========================================================
> -

extra line removal, but fine as clean-up to tag along I guess.




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH proxmox-backup] docs: notifications: fix broken calendar match examples
  2026-07-23 22:00 ` Thomas Lamprecht
@ 2026-07-24  5:21   ` Arthur Bied-Charreton
  0 siblings, 0 replies; 3+ messages in thread
From: Arthur Bied-Charreton @ 2026-07-24  5:21 UTC (permalink / raw)
  To: Thomas Lamprecht; +Cc: pbs-devel

On Fri, Jul 24, 2026 at 12:00:01AM +0200, Thomas Lamprecht wrote:
> Am 23.07.26 um 13:45 schrieb Arthur Bied-Charreton:
> > The calendar matcher examples showed weekday ranges as start-end. The
> > correct syntax is start..end - these example configs do not parse.
> > 
> > Update the examples to the correct a..b range syntax.
> > 
> > Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
> > ---
> >  docs/notifications.rst | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> > 
> > diff --git a/docs/notifications.rst b/docs/notifications.rst
> > index 440c700a4..7d6517dd7 100644
> > --- a/docs/notifications.rst
> > +++ b/docs/notifications.rst
> > @@ -217,8 +217,8 @@ Examples:
> >  
> >  * ``match-calendar 8-12``
> 
> Shouldn't above also change? or is that hours? These examples here
> would IMO do very well with actually explaining what each means, it's
> not exactly clear as it stands. A reference to the calendar events
> appendix at _calendar-event-scheduling would already help a lot and
> might we warranted either way, if this here is really using that format.

those are hours, our daytime ranges only accept '-' as delimiter, '..'
fails to parse. from a quick look at the proxmox-time code, it should be
quite easy to align this behavior with systemd, i.e. to allow both '-'
and '..' for weekday ranges and only '-' for daytime ranges. what do you
think?

you're right that these docs could use a touch-up, will send a v2 after
coordinating with Lukas W. 

> >  * ``match-calendar 8:00-15:30``
> > -* ``match-calendar mon-fri 9:00-17:00``
> 
> FWIW; systemd-analyze calendar "mon-fri" works, but it does normalize
> it to mon..fri
> 
thanks for the context!
> > -* ``match-calendar sun,tue-wed,fri 9-17``
> > +* ``match-calendar mon..fri 9:00-17:00``
> > +* ``match-calendar sun,tue..wed,fri 9-17``
> >  
> >  Field Matching Rules
> >  ^^^^^^^^^^^^^^^^^^^^
> > @@ -417,4 +417,3 @@ Counter Threshold    Description and Usage
> >  ``s3-download``      Amount of bytes downloaded from the S3 endpoint,
> >                       independent of request method.
> >  ==================== ==========================================================
> > -
> 
> extra line removal, but fine as clean-up to tag along I guess.
did not notice that, sorry for the noise




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-07-24  5:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-23 11:45 [PATCH proxmox-backup] docs: notifications: fix broken calendar match examples Arthur Bied-Charreton
2026-07-23 22:00 ` Thomas Lamprecht
2026-07-24  5:21   ` Arthur Bied-Charreton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal