all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>,
	pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-backup] docs: notifications: fix broken calendar match examples
Date: Fri, 24 Jul 2026 00:00:01 +0200	[thread overview]
Message-ID: <ea412c1b-fc19-4490-8105-c7113191d85e@proxmox.com> (raw)
In-Reply-To: <20260723114548.319543-1-a.bied-charreton@proxmox.com>

Am 23.07.26 um 13:45 schrieb Arthur Bied-Charreton:
> The calendar matcher examples showed weekday ranges as start-end. The
> correct syntax is start..end - these example configs do not parse.
> 
> Update the examples to the correct a..b range syntax.
> 
> Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
> ---
>  docs/notifications.rst | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/docs/notifications.rst b/docs/notifications.rst
> index 440c700a4..7d6517dd7 100644
> --- a/docs/notifications.rst
> +++ b/docs/notifications.rst
> @@ -217,8 +217,8 @@ Examples:
>  
>  * ``match-calendar 8-12``

Shouldn't above also change? or is that hours? These examples here
would IMO do very well with actually explaining what each means, it's
not exactly clear as it stands. A reference to the calendar events
appendix at _calendar-event-scheduling would already help a lot and
might we warranted either way, if this here is really using that format.

>  * ``match-calendar 8:00-15:30``
> -* ``match-calendar mon-fri 9:00-17:00``

FWIW; systemd-analyze calendar "mon-fri" works, but it does normalize
it to mon..fri

> -* ``match-calendar sun,tue-wed,fri 9-17``
> +* ``match-calendar mon..fri 9:00-17:00``
> +* ``match-calendar sun,tue..wed,fri 9-17``
>  
>  Field Matching Rules
>  ^^^^^^^^^^^^^^^^^^^^
> @@ -417,4 +417,3 @@ Counter Threshold    Description and Usage
>  ``s3-download``      Amount of bytes downloaded from the S3 endpoint,
>                       independent of request method.
>  ==================== ==========================================================
> -

extra line removal, but fine as clean-up to tag along I guess.




      reply	other threads:[~2026-07-23 22:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-23 11:45 [PATCH proxmox-backup] docs: notifications: fix broken calendar match examples Arthur Bied-Charreton
2026-07-23 22:00 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea412c1b-fc19-4490-8105-c7113191d85e@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=a.bied-charreton@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal