Re: [PATCH manager v4 00/12] ui: split out disks and nics into grids

[Jonas Theisen <j.theisen@proxmox.com>]

On 8/31/26 15:20, Jonas Theisen wrote:
> On 8/31/26 14:29, Dominik Csapak wrote:
>> Same as v3 of the series, basically just a rebase so it applies again.
>>
>> I factored out a few things, so it's easier to reuse (especially since i
>> want to do the same thing for containers when we figured out if the
>> style/layout/etc. fits)
>>
>> Sending again qemu only for now as i don't want to put in a lot of work
>> before we know which direction this will take.
>>
>> I tried to keep most commits small so it's easier to see what the actual
>> change are.
>>
>> NOTE: I took special care for the button enablement logic, but having 
>> a close
>> look at that during review would make a lot of sense.
>>
>> -snip-
>
> Tested the patch quickly and looks very good and improves user 
> readability
> a lot imho.
> A few things i noticed:
> * Unused disk stays above EFI and TPM disks while it would drop to the 
> bottom
> of the list pre-patch. Might be intended but noticed that.
> * Accessibility issue: If the new containers do not fit in the window 
> size, they are
> not scrollable vertically so you have to resize your window or shrink the
> Tasks view.
> * Also as already discussed in v1 with David Riley the horizontal 
> scrollbar
> is interfering with readability of the contents of the last or only item.
> But this is probably beyond the scope of this patch.
> https://lore.proxmox.com/pve-devel/c0fa8494-a5b2-44cd-b02d-3f9925fcae65@proxmox.com/ 
>
> * Revert button only updates on un- and reclick. Meaning that after a 
> change
> which could be reverted, the button stays disabled until the entry is 
> deselected
> and reselected. Same the other way around, where after a revert, the 
> Revert button
> would stay enabled after the change is already reverted.
> * EFI Disk: "Volume/File" and "Size" are empty while for TPM state 
> they are populated
> * EFI Disk: Will the EFI cert enrollment status i.e. ms-cert=### be 
> parsed and displayed?
>
> -- 
> Tested-by: Jonas Theisen <j.theisen@proxmox.com>

Addendum:
* column "Async I/O" is empty for the Default setting while for "Cache" 
it displays
"Default (No cache)". Would expect "Default (io_uring)" as shown in the 
Edit panel