From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager v4 10/12] ui: qemu: hardware view: separate nics into own grid
Date: Mon, 31 Aug 2026 14:27:45 +0200 [thread overview]
Message-ID: <20260831122953.2980232-11-d.csapak@proxmox.com> (raw)
In-Reply-To: <20260831122953.2980232-1-d.csapak@proxmox.com>
by using the newly added HardwareNetGrid and ConfigRemoveButton.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/qemu/HardwareView.js | 67 +++++++++++++++++++++++++++----
1 file changed, 59 insertions(+), 8 deletions(-)
diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js
index c4318851..abd6bb35 100644
--- a/www/manager6/qemu/HardwareView.js
+++ b/www/manager6/qemu/HardwareView.js
@@ -680,7 +680,7 @@ Ext.define('PVE.qemu.HardwareView', {
url: `/api2/json/nodes/${nodename}/qemu/${vmid}/pending`,
interval: 5000,
rows,
- filters: [(rec) => !diskGridFilter(rec)],
+ filters: [(rec) => !diskGridFilter(rec), (rec) => !PVE.Utils.keyIsNic(rec.data.key)],
});
let onSelectionChange = function (sm, selected) {
@@ -756,13 +756,6 @@ Ext.define('PVE.qemu.HardwareView', {
disabled: !caps.vms['VM.Config.CDROM'],
handler: editorFactory('CDEdit'),
},
- {
- text: gettext('Network Device'),
- itemId: 'addNet',
- iconCls: 'fa fa-fw fa-exchange black',
- disabled: !caps.vms['VM.Config.Network'],
- handler: editorFactory('NetworkEdit'),
- },
{
text: gettext('USB Device'),
itemId: 'addUsb',
@@ -1047,6 +1040,64 @@ Ext.define('PVE.qemu.HardwareView', {
},
],
},
+ // spacer with bottom border
+ {
+ xtype: 'panel',
+ border: true,
+ height: 1,
+ margin: '20 0 0 0',
+ },
+ {
+ xtype: 'pveHardwareNetGrid',
+ rstore: me.rstore,
+ store: {
+ sorter: sorterFn,
+ },
+ renderKey: function () {
+ let hardwareGrid = me.lookup('hardwareGrid');
+ return hardwareGrid.renderKey(...arguments);
+ },
+ listeners: {
+ itemdblclick: run_editor,
+ selectionchange: onSelectionChange,
+ },
+ tbar: [
+ {
+ text: gettext('Add'),
+ itemId: 'addNet',
+ disabled: !caps.vms['VM.Config.Network'],
+ handler: editorFactory('NetworkEdit'),
+ },
+ {
+ xtype: 'proxmoxButton',
+ text: gettext('Edit'),
+ disabled: true,
+ enableFn: (rec) =>
+ diskCap && !rec.data.deleted && !!rows[rec.data.key].editor,
+ handler: run_editor,
+ },
+ {
+ xtype: 'pveConfigRemoveButton',
+ baseurl,
+ rows,
+ reloadCallback: () => me.reload(),
+ renderKey: function () {
+ return me.lookup('hardwareGrid').renderKey(...arguments);
+ },
+ enableFn: (rec) =>
+ caps.vms['VM.Config.Network'] &&
+ !rec.data.deleted &&
+ !rows[rec.data.key].never_delete,
+ },
+ {
+ xtype: 'pvePendingRevertButton',
+ apiurl: '/api2/extjs/' + baseurl,
+ parentXType: 'pvePendingGrid',
+ enableFn: (rec) => !!rec.data.deleted || !!rec.data.pending,
+ reloadCallback: () => me.reload(),
+ },
+ ],
+ },
],
});
--
2.47.3
next prev parent reply other threads:[~2026-08-31 12:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 12:27 [PATCH manager v4 00/12] ui: split out disks and nics into grids Dominik Csapak
2026-08-31 12:27 ` [PATCH manager v4 01/12] ui: utils: factor out 'media=cdrom' check Dominik Csapak
2026-08-31 12:27 ` [PATCH manager v4 02/12] ui: factor out the guest key nic regex check Dominik Csapak
2026-08-31 12:27 ` [PATCH manager v4 03/12] ui: add pending grid Dominik Csapak
2026-08-31 12:27 ` [PATCH manager v4 04/12] ui: revert button: add parentXType and reloadCallback Dominik Csapak
2026-08-31 12:27 ` [PATCH manager v4 05/12] ui: button: add config remove button Dominik Csapak
2026-08-31 12:27 ` [PATCH manager v4 06/12] ui: qemu: hardware: wrap in container Dominik Csapak
2026-08-31 12:27 ` [PATCH manager v4 07/12] ui: qemu: introduce hardware disk grid Dominik Csapak
2026-08-31 12:27 ` [PATCH manager v4 08/12] ui: qemu: introduce hardware net grid Dominik Csapak
2026-08-31 12:27 ` [PATCH manager v4 09/12] ui: qemu: hardware view: separate disks into own grid Dominik Csapak
2026-08-31 12:27 ` Dominik Csapak [this message]
2026-08-31 12:27 ` [PATCH manager v4 11/12] ui: qemu: hardware view: inline edit/remove/revert button in general grid Dominik Csapak
2026-08-31 12:27 ` [PATCH manager v4 12/12] ui: qemu: hardware view: inline 'add efi' menuitem Dominik Csapak
2026-08-31 13:20 ` [PATCH manager v4 00/12] ui: split out disks and nics into grids Jonas Theisen
2026-08-31 14:11 ` Aaron Lauterer
2026-08-31 14:38 ` Jonas Theisen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260831122953.2980232-11-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.