From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id DCB781FF09B for ; Mon, 31 Aug 2026 16:38:29 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 435592097F; Mon, 31 Aug 2026 16:38:29 +0200 (CEST) Message-ID: Date: Mon, 31 Aug 2026 16:38:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH manager v4 00/12] ui: split out disks and nics into grids To: pve-devel@lists.proxmox.com References: <20260831122953.2980232-1-d.csapak@proxmox.com> Content-Language: en-US From: Jonas Theisen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1788187091438 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.581 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: CJR776KS2XSPT3DGJ3UMZ4NT7XI3WVZG X-Message-ID-Hash: CJR776KS2XSPT3DGJ3UMZ4NT7XI3WVZG X-MailFrom: j.theisen@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 8/31/26 15:20, Jonas Theisen wrote: > On 8/31/26 14:29, Dominik Csapak wrote: >> Same as v3 of the series, basically just a rebase so it applies again. >> >> I factored out a few things, so it's easier to reuse (especially since i >> want to do the same thing for containers when we figured out if the >> style/layout/etc. fits) >> >> Sending again qemu only for now as i don't want to put in a lot of work >> before we know which direction this will take. >> >> I tried to keep most commits small so it's easier to see what the actual >> change are. >> >> NOTE: I took special care for the button enablement logic, but having >> a close >> look at that during review would make a lot of sense. >> >> -snip- > > Tested the patch quickly and looks very good and improves user > readability > a lot imho. > A few things i noticed: > * Unused disk stays above EFI and TPM disks while it would drop to the > bottom > of the list pre-patch. Might be intended but noticed that. > * Accessibility issue: If the new containers do not fit in the window > size, they are > not scrollable vertically so you have to resize your window or shrink the > Tasks view. > * Also as already discussed in v1 with David Riley the horizontal > scrollbar > is interfering with readability of the contents of the last or only item. > But this is probably beyond the scope of this patch. > https://lore.proxmox.com/pve-devel/c0fa8494-a5b2-44cd-b02d-3f9925fcae65@proxmox.com/ > > * Revert button only updates on un- and reclick. Meaning that after a > change > which could be reverted, the button stays disabled until the entry is > deselected > and reselected. Same the other way around, where after a revert, the > Revert button > would stay enabled after the change is already reverted. > * EFI Disk: "Volume/File" and "Size" are empty while for TPM state > they are populated > * EFI Disk: Will the EFI cert enrollment status i.e. ms-cert=### be > parsed and displayed? > > -- > Tested-by: Jonas Theisen Addendum: * column "Async I/O" is empty for the Default setting while for "Cache" it displays "Default (No cache)". Would expect "Default (io_uring)" as shown in the Edit panel