Re: applied: [PATCH qemu-server v5 0/3] improve guest cleanup handling

[Dominik Csapak <d.csapak@proxmox.com>]

On 5/18/26 12:46 PM, Thomas Lamprecht wrote:
> On Fri, 15 May 2026 14:23:03 +0200, Dominik Csapak wrote:
>> First we make the cleanup handling more consistent (1/3)
>> then we check explicitely for the backup lock to improve the error
>> message for stop backup mode (2/3)
>> and then we fix #7119 by waiting up to 30s for a possibly still running
>> guest to stop (e.g. this can occur when using usb passthrouh) (3/3)
>>
>> changes from v4:
>> * only warn after 10 seconds exactly once, to indicate this is not a
>>    normal situation
>> * drop the 'waiting for xx seconds' from warning message
>>
>> [...]
> 
> Applied, thanks!
> 
> [1/3] cleanup: refactor to make cleanup flow consistent
>        commit: 7d48d8ba6fff6cda24c00adc8aedc9c6b3b46e52
> [2/3] qm cleanup: die early when encountering a running stop mode backup
>        commit: dd0fe2dfd6abe7a0af8faacfec755337a4d138be
> [3/3] fix #7119: qm cleanup: wait for process exiting for up to 30 seconds
>        commit: adebb9715ce9cea0adca36f6684726b3a3a32a47
> 
> A few small fix-ups:
> 

thanks!


> - Bumped the preinst threshold from 9.1.12 to 9.1.13, the version this
>    actually landed in.
> - Added an optional skip_hookscript param to vm_stop_cleanup and pass it
>    true from QemuMigrate's source-side call - moving exec_hookscript into
>    vm_stop_cleanup would otherwise newly fire the hook on every migration
>    (the previous callsite was short-circuited there). Might be good to cross
>    check though.

I'll test it shortly, but I think the post-stop hook was already 
triggered in that case by the 'qm cleanup' call so now it won't be 
triggered at all for live migrations?

the 'post-stop' hook on the source side was AFAIR also intended to do
some manual cleanup when the qemu process was migrated away so
I think it's missing now.

(but let me get back to that after testing with an older version)

> - Made the preinst marker write best-effort (touch ... || echo "..." >&2)
>    so a /run hiccup downgrades to a warning instead of aborting the
>    upgrade.
> - Renamed the marker to /run/qemu-server/force-legacy-cleanup; clearer
>    intent than 'use_old_cleanup'.
> - Shortened the commit message body to roughly half.