all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Dominik Csapak <d.csapak@proxmox.com>
Subject: applied: [PATCH qemu-server v5 0/3] improve guest cleanup handling
Date: Mon, 18 May 2026 12:46:23 +0200	[thread overview]
Message-ID: <177909704328.3037978.11473518831845296016.b4-ty@b4> (raw)
In-Reply-To: <20260515122437.3153051-1-d.csapak@proxmox.com>

On Fri, 15 May 2026 14:23:03 +0200, Dominik Csapak wrote:
> First we make the cleanup handling more consistent (1/3)
> then we check explicitely for the backup lock to improve the error
> message for stop backup mode (2/3)
> and then we fix #7119 by waiting up to 30s for a possibly still running
> guest to stop (e.g. this can occur when using usb passthrouh) (3/3)
> 
> changes from v4:
> * only warn after 10 seconds exactly once, to indicate this is not a
>   normal situation
> * drop the 'waiting for xx seconds' from warning message
> 
> [...]

Applied, thanks!

[1/3] cleanup: refactor to make cleanup flow consistent
      commit: 7d48d8ba6fff6cda24c00adc8aedc9c6b3b46e52
[2/3] qm cleanup: die early when encountering a running stop mode backup
      commit: dd0fe2dfd6abe7a0af8faacfec755337a4d138be
[3/3] fix #7119: qm cleanup: wait for process exiting for up to 30 seconds
      commit: adebb9715ce9cea0adca36f6684726b3a3a32a47

A few small fix-ups:

- Bumped the preinst threshold from 9.1.12 to 9.1.13, the version this
  actually landed in.
- Added an optional skip_hookscript param to vm_stop_cleanup and pass it
  true from QemuMigrate's source-side call - moving exec_hookscript into
  vm_stop_cleanup would otherwise newly fire the hook on every migration
  (the previous callsite was short-circuited there). Might be good to cross
  check though.
- Made the preinst marker write best-effort (touch ... || echo "..." >&2)
  so a /run hiccup downgrades to a warning instead of aborting the
  upgrade.
- Renamed the marker to /run/qemu-server/force-legacy-cleanup; clearer
  intent than 'use_old_cleanup'.
- Shortened the commit message body to roughly half.




  parent reply	other threads:[~2026-05-18 10:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-15 12:23 [PATCH qemu-server v5 0/3] improve guest cleanup handling Dominik Csapak
2026-05-15 12:23 ` [PATCH qemu-server v5 1/3] cleanup: refactor to make cleanup flow consistent Dominik Csapak
2026-05-15 12:23 ` [PATCH qemu-server v5 2/3] qm cleanup: die early when encountering a running stop mode backup Dominik Csapak
2026-05-15 12:23 ` [PATCH qemu-server v5 3/3] fix #7119: qm cleanup: wait for process exiting for up to 30 seconds Dominik Csapak
2026-05-15 13:05 ` [PATCH qemu-server v5 0/3] improve guest cleanup handling Fiona Ebner
2026-05-18 10:46 ` Thomas Lamprecht [this message]
2026-05-18 11:08   ` applied: " Dominik Csapak
2026-05-18 11:20     ` Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=177909704328.3037978.11473518831845296016.b4-ty@b4 \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal