[PATCH qemu-server v5 0/3] improve guest cleanup handling

[Dominik Csapak <d.csapak@proxmox.com>]

First we make the cleanup handling more consistent (1/3)
then we check explicitely for the backup lock to improve the error
message for stop backup mode (2/3)
and then we fix #7119 by waiting up to 30s for a possibly still running
guest to stop (e.g. this can occur when using usb passthrouh) (3/3)

changes from v4:
* only warn after 10 seconds exactly once, to indicate this is not a
  normal situation
* drop the 'waiting for xx seconds' from warning message

changes from v3:
* update version in preinst check
* add #DEBHELPER# to preinst
* consistently use /run/ instead of /var/run
* make get_cleanup_flag_path public and use that for mocking in tests
* style fixes
* use non-deprecated is_running helper
* improve warning message

changes from v2/RFC:
* use 'vm_running_locally' for getting the pid
* improve error messages
* use a 'use_old_cleanup' flag that will be auto-removed by a reboot
  to signal if we can use the new cleanup logic or the old


Dominik Csapak (3):
  cleanup: refactor to make cleanup flow consistent
  qm cleanup: die early when encountering a running stop mode backup
  fix #7119: qm cleanup: wait for process exiting for up to 30 seconds

 debian/preinst                   | 18 +++++++++++++
 src/PVE/CLI/qm.pm                | 43 ++++++++++++++++++++++++++++----
 src/PVE/QemuServer.pm            | 14 +++++++++++
 src/PVE/QemuServer/RunState.pm   | 29 +++++++++++++++++++++
 src/test/MigrationTest/QmMock.pm | 11 ++++++++
 5 files changed, 110 insertions(+), 5 deletions(-)
 create mode 100755 debian/preinst

-- 
2.47.3