From: Gabriel Goller <g.goller@proxmox.com>
To: Stefan Hanreich <s.hanreich@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH docs/gui-tests/manager/network/proxmox{-ve-rs,-perl-rs} v3 00/13] Add IS-IS protocol to fabrics
Date: Tue, 1 Sep 2026 12:26:15 +0200 [thread overview]
Message-ID: <apan-plMhtL76lNJ@luna.proxmox.com> (raw)
In-Reply-To: <apacfLN1uvYh-xcv@luna.proxmox.com>
On 01.09.2026 11:59, Gabriel Goller wrote:
> On 01.09.2026 10:58, Stefan Hanreich wrote:
> >
> >
> > On 9/1/26 10:55 AM, Hannes Laimer wrote:
> > > On 2026-09-01 10:33, Gabriel Goller wrote:
> > >> On 01.09.2026 09:09, Hannes Laimer wrote:
> > >>> On 2026-08-31 14:59, Gabriel Goller wrote:
> > >>>> On 31.08.2026 14:27, Gabriel Goller wrote:
> > >>>>> On 31.08.2026 10:48, Hannes Laimer wrote:
> > >>>>>> Aside from these very tiny nits/questions, looks very good to me:
> > >>>>>> - could we have the same `network_type`-nob here that we introduced for
> > >>>>>> OSPF?
> > >>>>>
> > >>>>> Yes, makes sense. ISIS supports network-type broadcast (unlike openfabric) and
> > >>>>> even multi-access (e.g. multiple devices behind a switch).
> > >>>>
> > >>>> Oh, no wait I won't be adding this. ISIS only has broadcast and point-to-point
> > >>>> available, and the default is broadcast. We use broadcast when an interface ip
> > >>>> is set and point-to-point when no ip is set.
> > >>>>
> > >>>
> > >>> yes, but we only need a specified ip for v4 broadcast, v6 does not. so
> > >>> unnumbered v6 broadcast is not possible currently
> > >>
> > >> Hmm that's true. v6 broadcast works in two scenarios: link-local addresses
> > >> (which IMO is not "unnumbered" -- but this is debatable :)), and because it uses
> > >> ndp instead of arp, which doesn't have the weird address-selection.
> > >>
> > >> I thought a while back about this -- we don't need to duplicate the ipv6
> > >> addresses to the interface. But then we should also remove the link-local
> > >> addresses to make it clean.
> > >
> > > i don't think we can, the ll would be the next-hop..
> >
> > My thoughts exactly, unless I'm missing something?
>
> Works without a nexthop using the onlink flag. But I forgot this is not merged
> yet, so nevermind (https://github.com/FRRouting/frr/pull/19429).
Oh, nevermind, this was already a long time ago -_-. You still need ll for ndp
to get the mac address. It would be possible with linux ppp interfaces, but they
are weird.
> > >>> the ip for the nic is taken from the node config, so leaving the nic ip
> > >>> fields empty doesn't necesarrily mean do p2p, p2p still needs a
> > >>> next-htop target and for v4 this has to be specified. we just take the
> > >>> ip from the node, which is fine. but leaving the ip field empty does not
> > >>> imply do `p2p`, just: use the node-ip for either(p2p or broadcast).
> > >>>
> > >>> for v6 we could actually never copy the node-ip to the nic(we do that
> > >>> now always), this would allow configuring unnumbered v6 broadcast or
> > >>> p2p, which are both possible with v6.
> > >>>
> > >>> [snip]
prev parent reply other threads:[~2026-09-01 10:26 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 11:32 [PATCH docs/gui-tests/manager/network/proxmox{-ve-rs,-perl-rs} v3 00/13] Add IS-IS protocol to fabrics Gabriel Goller
2026-08-28 11:32 ` [PATCH proxmox-ve-rs v3 01/13] frr: add fabric properties to ISIS types and rename domain Gabriel Goller
2026-08-28 11:32 ` [PATCH proxmox-ve-rs v3 02/13] ve-config: add IS-IS fabric config parsing and frr config generation Gabriel Goller
2026-08-28 11:32 ` [PATCH proxmox-ve-rs v3 03/13] ve-config: add integration tests for IS-IS fabrics Gabriel Goller
2026-08-28 11:32 ` [PATCH proxmox-ve-rs v3 04/13] ve-config: add IS-IS status deserialization types Gabriel Goller
2026-08-28 11:32 ` [PATCH proxmox-ve-rs v3 05/13] frr: accept legacy ISIS domain field Gabriel Goller
2026-08-28 11:32 ` [PATCH proxmox-perl-rs v3 06/13] pve-rs: fabrics: add IS-IS protocol ifupdown config generation Gabriel Goller
2026-08-28 11:32 ` [PATCH proxmox-perl-rs v3 07/13] sdn: add IS-IS fabric status reporting Gabriel Goller
2026-08-28 11:32 ` [PATCH pve-network v3 08/13] fabrics: add IS-IS api types Gabriel Goller
2026-08-31 8:39 ` Hannes Laimer
2026-08-31 13:29 ` Gabriel Goller
2026-09-01 7:42 ` Hannes Laimer
2026-08-28 11:32 ` [PATCH pve-network v3 09/13] sdn: controllers: rename isis domain to fabric_id Gabriel Goller
2026-08-28 11:32 ` [PATCH pve-manager v3 10/13] fabrics: add IS-IS panels Gabriel Goller
2026-08-28 11:32 ` [PATCH pve-manager v3 11/13] sdn: add warning about IS-IS controller deprecation Gabriel Goller
2026-08-28 11:32 ` [PATCH pve-docs v3 12/13] sdn: add section about IS-IS fabric Gabriel Goller
2026-08-28 11:32 ` [PATCH pve-gui-tests v3 13/13] fabrics: add screenshots for IS-IS fabric and nodes Gabriel Goller
2026-08-31 8:48 ` [PATCH docs/gui-tests/manager/network/proxmox{-ve-rs,-perl-rs} v3 00/13] Add IS-IS protocol to fabrics Hannes Laimer
2026-08-31 12:27 ` Gabriel Goller
2026-08-31 12:59 ` Gabriel Goller
2026-09-01 7:09 ` Hannes Laimer
2026-09-01 8:33 ` Gabriel Goller
2026-09-01 8:54 ` Hannes Laimer
2026-09-01 8:58 ` Stefan Hanreich
2026-09-01 9:59 ` Gabriel Goller
2026-09-01 10:26 ` Gabriel Goller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apan-plMhtL76lNJ@luna.proxmox.com \
--to=g.goller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.