all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Gabriel Goller <g.goller@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-network v3 08/13] fabrics: add IS-IS api types
Date: Fri, 28 Aug 2026 13:32:47 +0200	[thread overview]
Message-ID: <20260828113255.176546-9-g.goller@proxmox.com> (raw)
In-Reply-To: <20260828113255.176546-1-g.goller@proxmox.com>

Add IS-IS api-types and add it to the protocol enum. Also make 'isisd' a
frr daemon managed by pve (This means we can enable and disable it).

Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
 src/PVE/Network/SDN/Fabrics.pm | 51 ++++++++++++++++++++++++++++------
 src/PVE/Network/SDN/Frr.pm     |  1 +
 2 files changed, 44 insertions(+), 8 deletions(-)

diff --git a/src/PVE/Network/SDN/Fabrics.pm b/src/PVE/Network/SDN/Fabrics.pm
index 4f842f1013ef..7a6e936bf735 100644
--- a/src/PVE/Network/SDN/Fabrics.pm
+++ b/src/PVE/Network/SDN/Fabrics.pm
@@ -53,7 +53,7 @@ PVE::JSONSchema::register_standard_option(
     {
         description => "Type of configuration entry in an SDN Fabric section config",
         type => 'string',
-        enum => ['openfabric', 'ospf', 'wireguard', 'bgp'],
+        enum => ['openfabric', 'ospf', 'wireguard', 'bgp', 'isis'],
     },
 );
 
@@ -281,6 +281,41 @@ sub node_properties {
                     description => 'OpenFabric network interface',
                     optional => 1,
                 },
+                {
+                    type => 'array',
+                    'instance-types' => ['isis'],
+                    items => {
+                        type => 'string',
+                        format => {
+                            name => {
+                                type => 'string',
+                                format => 'pve-iface',
+                                description => 'Name of the network interface',
+                            },
+                            hello_multiplier => {
+                                type => 'integer',
+                                description => 'The hello_multiplier property of the interface',
+                                optional => 1,
+                                minimum => 2,
+                                maximum => 100,
+                            },
+                            ip => {
+                                type => 'string',
+                                format => 'CIDRv4',
+                                description => 'IPv4 address for this node',
+                                optional => 1,
+                            },
+                            ip6 => {
+                                type => 'string',
+                                format => 'CIDRv6',
+                                description => 'IPv6 address for this node',
+                                optional => 1,
+                            },
+                        },
+                    },
+                    description => 'IS-IS network interface',
+                    optional => 1,
+                },
                 {
                     type => 'array',
                     'instance-types' => ['ospf'],
@@ -438,7 +473,7 @@ sub node_properties {
                 },
                 {
                     type => 'array',
-                    'instance-types' => ['openfabric', 'ospf'],
+                    'instance-types' => ['openfabric', 'ospf', 'isis'],
                     items => {
                         type => 'string',
                         enum => ['interfaces', 'ip', 'ip6'],
@@ -484,8 +519,8 @@ sub fabric_properties {
         hello_interval => {
             type => 'number',
             'type-property' => 'protocol',
-            'instance-types' => ['openfabric'],
-            description => 'The hello_interval property for Openfabric',
+            'instance-types' => ['openfabric', 'isis'],
+            description => 'The hello_interval property for Openfabric and IS-IS',
             optional => 1,
             minimum => 1,
             maximum => 600,
@@ -493,8 +528,8 @@ sub fabric_properties {
         csnp_interval => {
             type => 'number',
             'type-property' => 'protocol',
-            'instance-types' => ['openfabric'],
-            description => 'The csnp_interval property for Openfabric',
+            'instance-types' => ['openfabric', 'isis'],
+            description => 'The csnp_interval property for Openfabric and IS-IS',
             optional => 1,
             minimum => 1,
             maximum => 600,
@@ -511,7 +546,7 @@ sub fabric_properties {
             type => 'string',
             format => 'pve-sdn-prefix-list-id',
             'type-property' => 'protocol',
-            'instance-types' => ['ospf', 'openfabric'],
+            'instance-types' => ['ospf', 'openfabric', 'isis'],
             description =>
                 'A prefix list that should be used for filtering routes that are to be installed into the kernel routing table',
             optional => 1,
@@ -598,7 +633,7 @@ sub fabric_properties {
             oneOf => [
                 {
                     type => 'array',
-                    'instance-types' => ['openfabric'],
+                    'instance-types' => ['openfabric', 'isis'],
                     items => {
                         type => 'string',
                         enum => [
diff --git a/src/PVE/Network/SDN/Frr.pm b/src/PVE/Network/SDN/Frr.pm
index f81da325b1ef..729feb9e6cbd 100644
--- a/src/PVE/Network/SDN/Frr.pm
+++ b/src/PVE/Network/SDN/Frr.pm
@@ -126,6 +126,7 @@ my $SDN_DAEMONS_DEFAULT = {
     ospfd => 0,
     fabricd => 0,
     bgpd => 1,
+    isisd => 1,
 };
 
 =head3 set_daemon_status(\%daemons, $set_default)
-- 
2.47.3





  parent reply	other threads:[~2026-08-28 11:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-28 11:32 [PATCH docs/gui-tests/manager/network/proxmox{-ve-rs,-perl-rs} v3 00/13] Add IS-IS protocol to fabrics Gabriel Goller
2026-08-28 11:32 ` [PATCH proxmox-ve-rs v3 01/13] frr: add fabric properties to ISIS types and rename domain Gabriel Goller
2026-08-28 11:32 ` [PATCH proxmox-ve-rs v3 02/13] ve-config: add IS-IS fabric config parsing and frr config generation Gabriel Goller
2026-08-28 11:32 ` [PATCH proxmox-ve-rs v3 03/13] ve-config: add integration tests for IS-IS fabrics Gabriel Goller
2026-08-28 11:32 ` [PATCH proxmox-ve-rs v3 04/13] ve-config: add IS-IS status deserialization types Gabriel Goller
2026-08-28 11:32 ` [PATCH proxmox-ve-rs v3 05/13] frr: accept legacy ISIS domain field Gabriel Goller
2026-08-28 11:32 ` [PATCH proxmox-perl-rs v3 06/13] pve-rs: fabrics: add IS-IS protocol ifupdown config generation Gabriel Goller
2026-08-28 11:32 ` [PATCH proxmox-perl-rs v3 07/13] sdn: add IS-IS fabric status reporting Gabriel Goller
2026-08-28 11:32 ` Gabriel Goller [this message]
2026-08-28 11:32 ` [PATCH pve-network v3 09/13] sdn: controllers: rename isis domain to fabric_id Gabriel Goller
2026-08-28 11:32 ` [PATCH pve-manager v3 10/13] fabrics: add IS-IS panels Gabriel Goller
2026-08-28 11:32 ` [PATCH pve-manager v3 11/13] sdn: add warning about IS-IS controller deprecation Gabriel Goller
2026-08-28 11:32 ` [PATCH pve-docs v3 12/13] sdn: add section about IS-IS fabric Gabriel Goller
2026-08-28 11:32 ` [PATCH pve-gui-tests v3 13/13] fabrics: add screenshots for IS-IS fabric and nodes Gabriel Goller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260828113255.176546-9-g.goller@proxmox.com \
    --to=g.goller@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal