From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id D6D9F1FF0DF for ; Fri, 28 Aug 2026 13:33:39 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 7A2A621614; Fri, 28 Aug 2026 13:33:06 +0200 (CEST) From: Gabriel Goller To: pve-devel@lists.proxmox.com Subject: [PATCH pve-network v3 08/13] fabrics: add IS-IS api types Date: Fri, 28 Aug 2026 13:32:47 +0200 Message-ID: <20260828113255.176546-9-g.goller@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260828113255.176546-1-g.goller@proxmox.com> References: <20260828113255.176546-1-g.goller@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787916770937 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.465 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: I6AV2FVVCU2AHQOQU2SGD5UCUHP2VBWH X-Message-ID-Hash: I6AV2FVVCU2AHQOQU2SGD5UCUHP2VBWH X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Add IS-IS api-types and add it to the protocol enum. Also make 'isisd' a frr daemon managed by pve (This means we can enable and disable it). Signed-off-by: Gabriel Goller --- src/PVE/Network/SDN/Fabrics.pm | 51 ++++++++++++++++++++++++++++------ src/PVE/Network/SDN/Frr.pm | 1 + 2 files changed, 44 insertions(+), 8 deletions(-) diff --git a/src/PVE/Network/SDN/Fabrics.pm b/src/PVE/Network/SDN/Fabrics.pm index 4f842f1013ef..7a6e936bf735 100644 --- a/src/PVE/Network/SDN/Fabrics.pm +++ b/src/PVE/Network/SDN/Fabrics.pm @@ -53,7 +53,7 @@ PVE::JSONSchema::register_standard_option( { description => "Type of configuration entry in an SDN Fabric section config", type => 'string', - enum => ['openfabric', 'ospf', 'wireguard', 'bgp'], + enum => ['openfabric', 'ospf', 'wireguard', 'bgp', 'isis'], }, ); @@ -281,6 +281,41 @@ sub node_properties { description => 'OpenFabric network interface', optional => 1, }, + { + type => 'array', + 'instance-types' => ['isis'], + items => { + type => 'string', + format => { + name => { + type => 'string', + format => 'pve-iface', + description => 'Name of the network interface', + }, + hello_multiplier => { + type => 'integer', + description => 'The hello_multiplier property of the interface', + optional => 1, + minimum => 2, + maximum => 100, + }, + ip => { + type => 'string', + format => 'CIDRv4', + description => 'IPv4 address for this node', + optional => 1, + }, + ip6 => { + type => 'string', + format => 'CIDRv6', + description => 'IPv6 address for this node', + optional => 1, + }, + }, + }, + description => 'IS-IS network interface', + optional => 1, + }, { type => 'array', 'instance-types' => ['ospf'], @@ -438,7 +473,7 @@ sub node_properties { }, { type => 'array', - 'instance-types' => ['openfabric', 'ospf'], + 'instance-types' => ['openfabric', 'ospf', 'isis'], items => { type => 'string', enum => ['interfaces', 'ip', 'ip6'], @@ -484,8 +519,8 @@ sub fabric_properties { hello_interval => { type => 'number', 'type-property' => 'protocol', - 'instance-types' => ['openfabric'], - description => 'The hello_interval property for Openfabric', + 'instance-types' => ['openfabric', 'isis'], + description => 'The hello_interval property for Openfabric and IS-IS', optional => 1, minimum => 1, maximum => 600, @@ -493,8 +528,8 @@ sub fabric_properties { csnp_interval => { type => 'number', 'type-property' => 'protocol', - 'instance-types' => ['openfabric'], - description => 'The csnp_interval property for Openfabric', + 'instance-types' => ['openfabric', 'isis'], + description => 'The csnp_interval property for Openfabric and IS-IS', optional => 1, minimum => 1, maximum => 600, @@ -511,7 +546,7 @@ sub fabric_properties { type => 'string', format => 'pve-sdn-prefix-list-id', 'type-property' => 'protocol', - 'instance-types' => ['ospf', 'openfabric'], + 'instance-types' => ['ospf', 'openfabric', 'isis'], description => 'A prefix list that should be used for filtering routes that are to be installed into the kernel routing table', optional => 1, @@ -598,7 +633,7 @@ sub fabric_properties { oneOf => [ { type => 'array', - 'instance-types' => ['openfabric'], + 'instance-types' => ['openfabric', 'isis'], items => { type => 'string', enum => [ diff --git a/src/PVE/Network/SDN/Frr.pm b/src/PVE/Network/SDN/Frr.pm index f81da325b1ef..729feb9e6cbd 100644 --- a/src/PVE/Network/SDN/Frr.pm +++ b/src/PVE/Network/SDN/Frr.pm @@ -126,6 +126,7 @@ my $SDN_DAEMONS_DEFAULT = { ospfd => 0, fabricd => 0, bgpd => 1, + isisd => 1, }; =head3 set_daemon_status(\%daemons, $set_default) -- 2.47.3