From: "Dominik Rusovac" <d.rusovac@proxmox.com>
To: "Daniel Kral" <d.kral@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH pve-cluster v2 10/19] fix #7993: datacenter config: ad ha-{cpu,mem}-weight crs options
Date: Fri, 20 Nov 2026 11:05:15 +0100 [thread overview]
Message-ID: <DMZYCARNDXNE.2H05CKN8CMXNP@proxmox.com> (raw)
In-Reply-To: <DMZWLCLOCUQU.2TF9W9WLBO6JT@proxmox.com>
On Fri Nov 20, 2026 at 9:43 AM CET, Daniel Kral wrote:
> On Thu Nov 12, 2026 at 10:44 AM CET, Dominik Rusovac wrote:
>> add weights controlling how much balancing the CPU load, respectively
>> the memory usage, of nodes is prioritized relative to each other by the
>> static and dynamic scheduling modes
>>
>> the weights are not specific to automatic rebalancing, as they are also
>> used when selecting a node to start or recover a resource on, so they do
>> not require 'ha-auto-rebalance'
>>
>> if neither weight is set, the previous behavior is kept: selecting a
>> node and the TOPSIS method favor memory usage 5 times over CPU load,
>> while the bruteforce method weighs both equally. if only one weight is
>> set, the other one defaults to 1
>>
>> Signed-off-by: Dominik Rusovac <d.rusovac@proxmox.com>
>> ---
>>
>> Notes:
>> changes since v1:
>> * rename ha-auto-rebalance-{cpu,mem}-weight, as the weights are not
>> auto-rebalance specific
>> * add verbose_description
>> * reword commit
>>
>> src/PVE/DataCenterConfig.pm | 28 ++++++++++++++++++++++++++++
>> 1 file changed, 28 insertions(+)
>>
>> diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm
>> index 004122e..a678838 100644
>> --- a/src/PVE/DataCenterConfig.pm
>> +++ b/src/PVE/DataCenterConfig.pm
>> @@ -78,6 +78,34 @@ EODESC
>> description => "The minimum relative improvement in cluster node imbalance,"
>> . " in percent, to commit to a resource balancing migration.",
>> },
>> + 'ha-cpu-weight' => {
>> + type => 'integer',
>> + optional => 1,
>> + minimum => 0,
>> + default => 1,
>> + description => "How much balancing the CPU load of nodes is prioritized, relative to"
>> + . " 'ha-mem-weight'. Used for the 'static' and 'dynamic' scheduler modes.",
>> + verbose_description => "How much balancing the CPU load of nodes is prioritized,"
>> + . " relative to 'ha-mem-weight'. Used for the 'static' and 'dynamic' scheduler"
>> + . " modes, both for selecting a node to start or recover a resource on and for"
>> + . " the automatic rebalancing. Only the ratio of the weights matters. If"
>> + . " neither weight is set, selecting a node to start or recover a resource on and"
>> + . " the 'topsis' rebalancing method prioritize memory usage 5 times over CPU load.",
>
> This should also explain that setting '0' means that the CPU load is not
> accounted for at all.
>
> nit: Could also use a new line before the
> "If neither weights is set, ..." part so the quite specific case is
> a bit more separate from the more generic description.
>
> maybe even prefix that paragraph with "For backwards compatibility,
> ..."
>
ack, thx for the heads up
will also add that with both weights set to 0, weights are ignored and
no automatic rebalancing is done
>> + },
>> + 'ha-mem-weight' => {
>> + type => 'integer',
>> + optional => 1,
>> + minimum => 0,
>> + default => 1,
>> + description => "How much balancing the memory usage of nodes is prioritized, relative"
>> + . " to 'ha-cpu-weight'. Used for the 'static' and 'dynamic' scheduler modes.",
>> + verbose_description => "How much balancing the memory usage of nodes is prioritized,"
>> + . " relative to 'ha-cpu-weight'. Used for the 'static' and 'dynamic' scheduler"
>> + . " modes, both for selecting a node to start or recover a resource on and for"
>> + . " the automatic rebalancing. Only the ratio of the weights matters. If"
>> + . " neither weight is set, selecting a node to start or recover a resource on and"
>> + . " the 'topsis' rebalancing method prioritize memory usage 5 times over CPU load.",
>
> Same here as well
>
ack
>> + },
>> };
>>
>> my $migration_format = {
next prev parent reply other threads:[~2026-11-20 10:05 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 9:44 [RFC PATCH-SERIES cluster/ha-manager/manager/proxmox{,-perl-rs} v2 00/19] fix #7993: implement weighted crs load balancing Dominik Rusovac
2026-11-12 9:44 ` [PATCH proxmox v2 01/19] resource-scheduling: fix typos Dominik Rusovac
2026-11-19 12:27 ` Daniel Kral
2026-11-12 9:44 ` [PATCH proxmox v2 02/19] resource-scheduling: scheduler: refine score_* docs Dominik Rusovac
2026-11-19 12:27 ` Daniel Kral
2026-11-19 12:47 ` Dominik Rusovac
2026-11-12 9:44 ` [PATCH proxmox v2 03/19] resource-scheduling: scheduler: abstract post-migration stats logic Dominik Rusovac
2026-11-19 12:28 ` Daniel Kral
2026-11-19 12:47 ` Dominik Rusovac
2026-11-12 9:44 ` [PATCH proxmox v2 04/19] fix #7993: resource-scheduling: node: add weighted node load Dominik Rusovac
2026-11-19 12:28 ` Daniel Kral
2026-11-19 12:50 ` Dominik Rusovac
2026-11-12 9:44 ` [PATCH proxmox v2 05/19] resource-scheduling: scheduler: make imbalance with candidate public Dominik Rusovac
2026-11-19 12:41 ` Daniel Kral
2026-11-19 12:52 ` Dominik Rusovac
2026-11-12 9:44 ` [PATCH proxmox v2 06/19] fix #7993: resource-scheduling: scheduler: add weights Dominik Rusovac
2026-11-19 12:40 ` Daniel Kral
2026-11-19 13:52 ` Dominik Rusovac
2026-11-12 9:44 ` [PATCH proxmox v2 07/19] workspace,resource-scheduling: add proptest as dev-dependency Dominik Rusovac
2026-11-12 9:44 ` [PATCH proxmox v2 08/19] resource-scheduling: scheduler: add property tests for weights Dominik Rusovac
2026-11-12 9:44 ` [PATCH proxmox-perl-rs v2 09/19] fix #7993: pve-rs: resource-scheduling: add scheduler options Dominik Rusovac
2026-11-19 12:45 ` Daniel Kral
2026-11-19 13:28 ` Dominik Rusovac
2026-11-12 9:44 ` [PATCH pve-cluster v2 10/19] fix #7993: datacenter config: ad ha-{cpu,mem}-weight crs options Dominik Rusovac
2026-11-20 8:43 ` Daniel Kral
2026-11-20 10:05 ` Dominik Rusovac [this message]
2026-11-12 9:44 ` [PATCH pve-manager v2 11/19] ui: form: crs options: make fine-tuning options advanced Dominik Rusovac
2026-11-20 13:37 ` Daniel Kral
2026-11-20 13:55 ` Dominik Rusovac
2026-11-12 9:44 ` [PATCH pve-manager v2 12/19] fix #7993: ui: form: crs options: add weights Dominik Rusovac
2026-11-20 13:35 ` Daniel Kral
2026-11-20 13:49 ` Dominik Rusovac
2026-11-12 9:44 ` [PATCH pve-ha-manager v2 13/19] manager: remove obsolete argument Dominik Rusovac
2026-11-12 9:44 ` [PATCH pve-ha-manager v2 14/19] manager: rename update_crs_scheduler_mod to update_crs_settings Dominik Rusovac
2026-11-20 13:39 ` Daniel Kral
2026-11-12 9:44 ` [PATCH pve-ha-manager v2 15/19] manager: factor out crs option update helper Dominik Rusovac
2026-11-20 13:46 ` Daniel Kral
2026-11-20 14:02 ` Dominik Rusovac
2026-11-12 9:44 ` [PATCH pve-ha-manager v2 16/19] manager: log changes to crs settings Dominik Rusovac
2026-11-20 13:54 ` Daniel Kral
2026-11-12 9:44 ` [PATCH pve-ha-manager v2 17/19] sim: hardware: allow changing datacenter settings at runtime Dominik Rusovac
2026-11-12 9:44 ` [PATCH pve-ha-manager v2 18/19] fix #7993: manager,usage: use weights for static and dynamic mode Dominik Rusovac
2026-11-12 9:44 ` [PATCH pve-ha-manager v2 19/19] test: add automatic rebalancing test cases with weights Dominik Rusovac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMZYCARNDXNE.2H05CKN8CMXNP@proxmox.com \
--to=d.rusovac@proxmox.com \
--cc=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.