all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Dominik Rusovac" <d.rusovac@proxmox.com>
To: "Daniel Kral" <d.kral@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH proxmox v2 02/19] resource-scheduling: scheduler: refine score_* docs
Date: Thu, 19 Nov 2026 13:47:07 +0100	[thread overview]
Message-ID: <DMZ75OSXLVPP.3OR8D5XEOKPV8@proxmox.com> (raw)
In-Reply-To: <DMZ6QZTFUYDP.3TOMY0J5YTMVX@proxmox.com>

thx for the review!

On Thu Nov 19, 2026 at 1:27 PM CET, Daniel Kral wrote:
> On Thu Nov 12, 2026 at 10:44 AM CET, Dominik Rusovac wrote:

[snip]

>> to be more precise, refine parts of docs of functions responsible for
>> scoring migration candidates and selecting node to start service on,
>> respectively
>>
>> Signed-off-by: Dominik Rusovac <d.rusovac@proxmox.com>
>> ---
>>
>> Notes:
>>     new, split out of patch [0] in v1
>>     
>>     respective changes:
>>     * slightly reword docs
>>     
>>     [0] https://lore.proxmox.com/all/20261021085932.1196302-4-d.rusovac@proxmox.com/
>>
>>  proxmox-resource-scheduling/src/scheduler.rs | 12 ++++++------
>>  1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/proxmox-resource-scheduling/src/scheduler.rs b/proxmox-resource-scheduling/src/scheduler.rs
>> index 9078fa72..60e60d3c 100644
>> --- a/proxmox-resource-scheduling/src/scheduler.rs
>> +++ b/proxmox-resource-scheduling/src/scheduler.rs
>> @@ -228,15 +228,15 @@ impl Scheduler {
>>          })
>>      }
>>  
>> -    /// Scores the given migration `candidates` by the best node imbalance improvement with
>> -    /// exhaustive search.
>> +    /// Uses bruteforce search to score how much each of the given migration `candidates` improves
>> +    /// node imbalance and ranks them accordingly.
>
> nit: if possible start this with 'Scores'/'Ranks' here as well just to
>      be consistent with the TOPSIS doc
>

ack

>>      ///
>>      /// The `candidates` are assumed to be consistent with the scheduler. No further validation is
>>      /// done whether the given nodenames actually exist in the scheduler.
>>      ///
>>      /// The scoring is done as if each resource migration has already been done. This assumes that
>>      /// the already migrated resource consumes the same amount of each stat as on the previous node
>> -    /// according to its `stats`.
>> +    /// according to its `stats`. The lower the score, the better.
>>      ///
>>      /// Returns up to `limit` of the best scored migrations.
>>      pub fn score_best_balancing_migration_candidates<I>(
>> @@ -269,8 +269,7 @@ impl Scheduler {
>>          best_migrations
>>      }
>>  
>> -    /// Scores the given migration `candidates` by the best node imbalance improvement with the
>> -    /// TOPSIS method.
>> +    /// Scores the given migration `candidates` using the TOPSIS method.
>
> nit: maybe use 'Ranks' here as well and clarify that the 'score_' is a
>     misnomer in the commit message (I'm sorry ;-))
>

ack

[snip]




  reply	other threads:[~2026-11-19 12:47 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12  9:44 [RFC PATCH-SERIES cluster/ha-manager/manager/proxmox{,-perl-rs} v2 00/19] fix #7993: implement weighted crs load balancing Dominik Rusovac
2026-11-12  9:44 ` [PATCH proxmox v2 01/19] resource-scheduling: fix typos Dominik Rusovac
2026-11-19 12:27   ` Daniel Kral
2026-11-12  9:44 ` [PATCH proxmox v2 02/19] resource-scheduling: scheduler: refine score_* docs Dominik Rusovac
2026-11-19 12:27   ` Daniel Kral
2026-11-19 12:47     ` Dominik Rusovac [this message]
2026-11-12  9:44 ` [PATCH proxmox v2 03/19] resource-scheduling: scheduler: abstract post-migration stats logic Dominik Rusovac
2026-11-19 12:28   ` Daniel Kral
2026-11-19 12:47     ` Dominik Rusovac
2026-11-12  9:44 ` [PATCH proxmox v2 04/19] fix #7993: resource-scheduling: node: add weighted node load Dominik Rusovac
2026-11-19 12:28   ` Daniel Kral
2026-11-19 12:50     ` Dominik Rusovac
2026-11-12  9:44 ` [PATCH proxmox v2 05/19] resource-scheduling: scheduler: make imbalance with candidate public Dominik Rusovac
2026-11-19 12:41   ` Daniel Kral
2026-11-19 12:52     ` Dominik Rusovac
2026-11-12  9:44 ` [PATCH proxmox v2 06/19] fix #7993: resource-scheduling: scheduler: add weights Dominik Rusovac
2026-11-19 12:40   ` Daniel Kral
2026-11-19 13:52     ` Dominik Rusovac
2026-11-12  9:44 ` [PATCH proxmox v2 07/19] workspace,resource-scheduling: add proptest as dev-dependency Dominik Rusovac
2026-11-12  9:44 ` [PATCH proxmox v2 08/19] resource-scheduling: scheduler: add property tests for weights Dominik Rusovac
2026-11-12  9:44 ` [PATCH proxmox-perl-rs v2 09/19] fix #7993: pve-rs: resource-scheduling: add scheduler options Dominik Rusovac
2026-11-19 12:45   ` Daniel Kral
2026-11-19 13:28     ` Dominik Rusovac
2026-11-12  9:44 ` [PATCH pve-cluster v2 10/19] fix #7993: datacenter config: ad ha-{cpu,mem}-weight crs options Dominik Rusovac
2026-11-12  9:44 ` [PATCH pve-manager v2 11/19] ui: form: crs options: make fine-tuning options advanced Dominik Rusovac
2026-11-12  9:44 ` [PATCH pve-manager v2 12/19] fix #7993: ui: form: crs options: add weights Dominik Rusovac
2026-11-12  9:44 ` [PATCH pve-ha-manager v2 13/19] manager: remove obsolete argument Dominik Rusovac
2026-11-12  9:44 ` [PATCH pve-ha-manager v2 14/19] manager: rename update_crs_scheduler_mod to update_crs_settings Dominik Rusovac
2026-11-12  9:44 ` [PATCH pve-ha-manager v2 15/19] manager: factor out crs option update helper Dominik Rusovac
2026-11-12  9:44 ` [PATCH pve-ha-manager v2 16/19] manager: log changes to crs settings Dominik Rusovac
2026-11-12  9:44 ` [PATCH pve-ha-manager v2 17/19] sim: hardware: allow changing datacenter settings at runtime Dominik Rusovac
2026-11-12  9:44 ` [PATCH pve-ha-manager v2 18/19] fix #7993: manager,usage: use weights for static and dynamic mode Dominik Rusovac
2026-11-12  9:44 ` [PATCH pve-ha-manager v2 19/19] test: add automatic rebalancing test cases with weights Dominik Rusovac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMZ75OSXLVPP.3OR8D5XEOKPV8@proxmox.com \
    --to=d.rusovac@proxmox.com \
    --cc=d.kral@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal