all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Thomas Lamprecht" <t.lamprecht@proxmox.com>,
	"Mark Atwood" <mark@wolfssl.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH cluster v2 1/1] datacenter config: add ticket-signature-hash option
Date: Wed, 18 Nov 2026 10:40:38 +0100	[thread overview]
Message-ID: <DMY8KD0ZGUMK.QED7IOIXLGPK@proxmox.com> (raw)
In-Reply-To: <2a835c03-2787-48f8-a8e4-60bd05e35107@proxmox.com>

On Wed Nov 18, 2026 at 5:14 AM CET, Thomas Lamprecht wrote:
> Am 13.11.26 um 04:34 schrieb Mark Atwood:
>> Add a cluster-wide option to select the hash algorithm for the RSA
>> signature of newly created authentication tickets, either 'sha1' or
>> 'sha256'. It defaults to 'sha1', the algorithm used so far, so nothing
>> changes unless it is set explicitly.
>>
>> This allows running with crypto providers that refuse SHA-1
>> signatures, such as FIPS ones, where creating tickets does not work
>> otherwise. Consumers, i.e. pve-access-control, read the option when
>> creating tickets. Verification accepts both algorithms independent of
>> the option, once the nodes have the changes to PVE::Ticket in
>> pve-common. This affects Proxmox Mail Gateway only through that
>> module, it does not read this option.
>>
>> The option applies to the whole cluster, but nodes that do not know
>> how to verify SHA-256 reject such tickets. So it must only be set to
>> 'sha256' once all nodes have been upgraded, which the description
>> states. Enforcing this by checking the node versions is left for
>> later, as it needs to know the release that includes the verification
>> change.
>
> Any reason to stick with sha1 here? I mean, I have nothing against that
> per se, but as alternative we could also just switch over fully and
> then only do sha256 signatures?
>
> 1. add support for detecting and verifying sha256 now
> 2. enable it later (or with a cluster-version guard on pve-manager,
>    which we can use as leave package to transitively depend on new
>    enough cluster/access-control/common (or wherever this lifes).
>
> Then we would not have to harry that option around and all would benefit
> from stronger – albeit the difference being currently practically not
> really relevant – signature algo.
>
> I do not want to block your approach here, but it would be a potential
> alternative.

Hope it is ok to chime in here. This option was probably added on my
suggestion [1]. The version guard you suggest is likely a neater
solution code wise. The intent was to allow users that require FIPS
compliance to switch to SHA-256 sooner than the next major version is
released.

Using the cluster version guard helper [2] would come with one downside:
It als errors when not all nodes are online or the version information
is unreadable. In that case we'd probably want to fall back to SHA-1,
which for FIPS compliant nodes would mean that they can't log in if a
single node goes down. While logging in with TFA is already an issue in
an unquorate state, this would arguably be worse for FIPS users.

So we'd need to keep using SHA-256 at least until a new node joins with
a version that's too old. We could do that with a non-dying variant of
the helper that reads the stale info from pmxcfs as usually version
numbers only go up. However, nodes with an unknown version would remain
an issue. Alternatively we may want to add a fallback to SHA-256 if
signing with SHA-1 fails or allow an override similar to this approach.

The nice thing about this option is that it only depends on the state of
the local node. Even in an unquorate state the cluster config stays
readable as pmxcfs switches to read-only mode.

[1]: https://lore.proxmox.com/all/DMKS80347XID.3KPXPXVUHQ3ZG@proxmox.com/
[2]: https://git.proxmox.com/?p=pve-cluster.git;a=commitdiff;h=168ac114df




  reply	other threads:[~2026-11-18  9:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13  3:06 [PATCH cluster v2 0/1] datacenter config: add ticket-signature-hash option Mark Atwood
2026-11-13  3:06 ` [PATCH cluster v2 1/1] " Mark Atwood
2026-11-17 16:05   ` Shannon Sterz
2026-11-18  4:14   ` Thomas Lamprecht
2026-11-18  9:40     ` Shannon Sterz [this message]
2026-11-19 12:38       ` Thomas Lamprecht
2026-11-19 13:37         ` Shannon Sterz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMY8KD0ZGUMK.QED7IOIXLGPK@proxmox.com \
    --to=s.sterz@proxmox.com \
    --cc=mark@wolfssl.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal