all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Mark Atwood" <mark@wolfssl.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH cluster v2 1/1] datacenter config: add ticket-signature-hash option
Date: Tue, 17 Nov 2026 17:05:29 +0100	[thread overview]
Message-ID: <DMXM4H3KEIM0.3C96K1ZSGPLM5@proxmox.com> (raw)
In-Reply-To: <20261113030646.3533-2-mark@wolfssl.com>

On Fri Nov 13, 2026 at 4:06 AM CET, Mark Atwood wrote:
> Add a cluster-wide option to select the hash algorithm for the RSA
> signature of newly created authentication tickets, either 'sha1' or
> 'sha256'. It defaults to 'sha1', the algorithm used so far, so nothing
> changes unless it is set explicitly.
>
> This allows running with crypto providers that refuse SHA-1
> signatures, such as FIPS ones, where creating tickets does not work
> otherwise. Consumers, i.e. pve-access-control, read the option when
> creating tickets. Verification accepts both algorithms independent of
> the option, once the nodes have the changes to PVE::Ticket in
> pve-common. This affects Proxmox Mail Gateway only through that
> module, it does not read this option.
>
> The option applies to the whole cluster, but nodes that do not know
> how to verify SHA-256 reject such tickets. So it must only be set to
> 'sha256' once all nodes have been upgraded, which the description
> states. Enforcing this by checking the node versions is left for
> later, as it needs to know the release that includes the verification
> change.
>
> The tests check that both values and only those are accepted, and that
> the option is written back.
>
> Signed-off-by: Mark Atwood <mark@wolfssl.com>
> ---
>  src/PVE/DataCenterConfig.pm            | 16 +++++++++++
>  src/test/Makefile                      |  6 ++++-
>  src/test/test_ticket_signature_hash.pl | 37 ++++++++++++++++++++++++++
>  3 files changed, 58 insertions(+), 1 deletion(-)
>  create mode 100644 src/test/test_ticket_signature_hash.pl
>
> diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm
> index 004122e..6c96bbb 100644
> --- a/src/PVE/DataCenterConfig.pm
> +++ b/src/PVE/DataCenterConfig.pm
> @@ -551,6 +551,22 @@ my $datacenter_schema = {
>              description => "The location of the cluster.",
>              optional => 1,
>          },
> +        'ticket-signature-hash' => {
> +            optional => 1,
> +            type => 'string',
> +            enum => ['sha1', 'sha256'],
> +            default => 'sha1',
> +            description => "Hash algorithm that is used for the RSA signature of newly created"
> +                . " authentication tickets. Use 'sha256' if SHA-1 signatures are not acceptable,"
> +                . " for example when running in FIPS mode.",
> +            verbose_description => "Hash algorithm that is used for the RSA signature of newly"
> +                . " created authentication tickets. All nodes accept tickets signed with either"
> +                . " algorithm, but only nodes with SHA-256 support do so.\n\nThis setting is"

nit: this reads contradictory. maybe "All nodes accept tickets signed
with either algorithm, but tickets signed with SHA-256 require the nodes
to support verify such tickets."

-->8 snip 8<--




  reply	other threads:[~2026-11-17 16:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13  3:06 [PATCH cluster v2 0/1] datacenter config: add ticket-signature-hash option Mark Atwood
2026-11-13  3:06 ` [PATCH cluster v2 1/1] " Mark Atwood
2026-11-17 16:05   ` Shannon Sterz [this message]
2026-11-18  4:14   ` Thomas Lamprecht
2026-11-18  9:40     ` Shannon Sterz
2026-11-19 12:38       ` Thomas Lamprecht
2026-11-19 13:37         ` Shannon Sterz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMXM4H3KEIM0.3C96K1ZSGPLM5@proxmox.com \
    --to=s.sterz@proxmox.com \
    --cc=mark@wolfssl.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal