From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 16AC31FF0AA for ; Tue, 17 Nov 2026 17:05:51 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 8264621685; Tue, 17 Nov 2026 17:05:45 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 17 Nov 2026 17:05:29 +0100 Message-Id: Subject: Re: [PATCH cluster v2 1/1] datacenter config: add ticket-signature-hash option To: "Mark Atwood" , X-Mailer: aerc 0.20.0 References: <20261113030646.3533-1-mark@wolfssl.com> <20261113030646.3533-2-mark@wolfssl.com> In-Reply-To: <20261113030646.3533-2-mark@wolfssl.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794931529372 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.571 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: VJ4JWFB2RZRX6WFJVSNRTKEXCLEYRAHA X-Message-ID-Hash: VJ4JWFB2RZRX6WFJVSNRTKEXCLEYRAHA X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri Nov 13, 2026 at 4:06 AM CET, Mark Atwood wrote: > Add a cluster-wide option to select the hash algorithm for the RSA > signature of newly created authentication tickets, either 'sha1' or > 'sha256'. It defaults to 'sha1', the algorithm used so far, so nothing > changes unless it is set explicitly. > > This allows running with crypto providers that refuse SHA-1 > signatures, such as FIPS ones, where creating tickets does not work > otherwise. Consumers, i.e. pve-access-control, read the option when > creating tickets. Verification accepts both algorithms independent of > the option, once the nodes have the changes to PVE::Ticket in > pve-common. This affects Proxmox Mail Gateway only through that > module, it does not read this option. > > The option applies to the whole cluster, but nodes that do not know > how to verify SHA-256 reject such tickets. So it must only be set to > 'sha256' once all nodes have been upgraded, which the description > states. Enforcing this by checking the node versions is left for > later, as it needs to know the release that includes the verification > change. > > The tests check that both values and only those are accepted, and that > the option is written back. > > Signed-off-by: Mark Atwood > --- > src/PVE/DataCenterConfig.pm | 16 +++++++++++ > src/test/Makefile | 6 ++++- > src/test/test_ticket_signature_hash.pl | 37 ++++++++++++++++++++++++++ > 3 files changed, 58 insertions(+), 1 deletion(-) > create mode 100644 src/test/test_ticket_signature_hash.pl > > diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm > index 004122e..6c96bbb 100644 > --- a/src/PVE/DataCenterConfig.pm > +++ b/src/PVE/DataCenterConfig.pm > @@ -551,6 +551,22 @@ my $datacenter_schema =3D { > description =3D> "The location of the cluster.", > optional =3D> 1, > }, > + 'ticket-signature-hash' =3D> { > + optional =3D> 1, > + type =3D> 'string', > + enum =3D> ['sha1', 'sha256'], > + default =3D> 'sha1', > + description =3D> "Hash algorithm that is used for the RSA si= gnature of newly created" > + . " authentication tickets. Use 'sha256' if SHA-1 signat= ures are not acceptable," > + . " for example when running in FIPS mode.", > + verbose_description =3D> "Hash algorithm that is used for th= e RSA signature of newly" > + . " created authentication tickets. All nodes accept tic= kets signed with either" > + . " algorithm, but only nodes with SHA-256 support do so= .\n\nThis setting is" nit: this reads contradictory. maybe "All nodes accept tickets signed with either algorithm, but tickets signed with SHA-256 require the nodes to support verify such tickets." -->8 snip 8<--