From: "Nicolas Frey" <n.frey@proxmox.com>
To: "Dominik Csapak" <d.csapak@proxmox.com>, <yew-devel@lists.proxmox.com>
Subject: Re: [PATCH proxmox-yew-widget-toolkit 4/5] widget: form: implement multi select field
Date: Thu, 05 Nov 2026 11:17:22 +0100 [thread overview]
Message-ID: <DMN77EBU8WCD.3B1EDE7KSFINB@proxmox.com> (raw)
In-Reply-To: <1d940f6b-355d-46ed-80ba-e8e14f58503b@proxmox.com>
On Mon Nov 2, 2026 at 3:12 PM CET, Dominik Csapak wrote:
> some high level comments:
>
> I'd really like for this to follow the existing conventions for our
> other fields. It's Basically a Combobox but with multiselect, so I'd
> like to see either:
>
> * make it an option in combobox `.multiselect(true)`
> * or keep it separate but implement the same interface (with_item,
> triggers, etc.)
>
> (wheatever is easier)
>
> If it's a separate field, something like 'multicombobox' would
> maybe be more fitting? (to convey the combobox base)
thanks for the feedback! I'll see what feels better from the impl and
API consumer POV and follow up in a v2
[snip]
next prev parent reply other threads:[~2026-11-05 10:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 15:15 [PATCH proxmox-yew-widget-toolkit 0/5] add multi-select component Nicolas Frey
2026-10-28 15:15 ` [PATCH proxmox-yew-widget-toolkit 1/5] widget: data table: simplify lookup of keys near the cursor Nicolas Frey
2026-11-02 14:12 ` Dominik Csapak
2026-11-06 9:35 ` applied: " Dietmar Maurer
2026-10-28 15:15 ` [PATCH proxmox-yew-widget-toolkit 2/5] widget: data table: only extend explicit select all to new rows Nicolas Frey
2026-11-02 14:12 ` Dominik Csapak
2026-11-05 10:17 ` Nicolas Frey
2026-10-28 15:15 ` [PATCH proxmox-yew-widget-toolkit 3/5] widget: grid picker: keep selected records hidden by the filter Nicolas Frey
2026-11-02 14:12 ` Dominik Csapak
2026-11-05 10:17 ` Nicolas Frey
2026-10-28 15:15 ` [PATCH proxmox-yew-widget-toolkit 4/5] widget: form: implement multi select field Nicolas Frey
2026-11-02 14:12 ` Dominik Csapak
2026-11-05 10:17 ` Nicolas Frey [this message]
2026-11-02 14:23 ` Dominik Csapak
2026-11-05 10:17 ` Nicolas Frey
2026-11-05 10:36 ` Dominik Csapak
2026-10-28 15:15 ` [PATCH proxmox-yew-widget-toolkit 5/5] widget: form: combobox: update doc to point to `MultiSelect` Nicolas Frey
2026-11-02 14:12 ` Dominik Csapak
2026-11-05 10:17 ` Nicolas Frey
2026-11-02 14:12 ` [PATCH proxmox-yew-widget-toolkit 0/5] add multi-select component Dominik Csapak
2026-11-06 7:19 ` Dietmar Maurer
2026-11-06 8:41 ` Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMN77EBU8WCD.3B1EDE7KSFINB@proxmox.com \
--to=n.frey@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=yew-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.