Re: [PATCH datacenter-manager v5 20/21] pdm-config: subscriptions: drop unused accessor functions

["Lukas Wagner" <l.wagner@proxmox.com>]

On Thu Sep 3, 2026 at 8:19 PM CEST, Michael Köppl wrote:
> On Thu Sep 3, 2026 at 1:16 PM CEST, Lukas Wagner wrote:
>
> [snip]
>
>>  pub trait SubscriptionKeyConfig {
>>      fn read(&self) -> Result<(SectionConfigData<SubscriptionKeyEntry>, ConfigDigest), Error>;
>>      fn read_shadow(&self) -> Result<SectionConfigData<SubscriptionKeyShadow>, Error>;
>> @@ -110,9 +77,3 @@ impl SubscriptionKeyConfig for DefaultSubscriptionKeyConfig {
>>          replace_secret_config(SUBSCRIPTIONS_SHADOW_FILENAME, raw.as_bytes())
>>      }
>>  }
>> -
>> -pub fn init(instance: Box<dyn SubscriptionKeyConfig + Send + Sync>) {
>
> Same here regarding the reference in the module docs. It also leaves a
> dead reference.
>

Fixed as well, thanks a lot! Things like these are always easy to
overlook for me...

>> -    if INSTANCE.set(instance).is_err() {
>> -        panic!("subscription key config instance already set");
>> -    }
>> -}
>> diff --git a/server/src/context/mod.rs b/server/src/context/mod.rs
>> index 082ab8de..95238030 100644
>> --- a/server/src/context/mod.rs
>> +++ b/server/src/context/mod.rs
>> @@ -34,7 +34,6 @@ pub fn init() -> Result<PdmApplication, Error> {
>>      // anyway, and the implementation is stateless, so having this second
>>      // instance is not an issue *currently*.
>>      pdm_config::remotes::init(factory.make_remote_config()?);
>> -    pdm_config::subscriptions::init(factory.make_subscription_key_config()?);
>>  
>>      Ok(app)
>>  }