From: "Michael Köppl" <m.koeppl@proxmox.com>
To: "Lukas Wagner" <l.wagner@proxmox.com>, <pdm-devel@lists.proxmox.com>
Subject: Re: [PATCH datacenter-manager v5 12/21] connection: use client factory from PdmApplication handle
Date: Thu, 03 Sep 2026 20:19:50 +0200 [thread overview]
Message-ID: <DL5W0HIN4PJB.3NGWJKFKUX1TJ@proxmox.com> (raw)
In-Reply-To: <20260903111609.267762-13-l.wagner@proxmox.com>
On Thu Sep 3, 2026 at 1:16 PM CEST, Lukas Wagner wrote:
[snip]
> -/// Initialize the [`ClientFactory`] instance.
> -///
> -/// Will panic if the instance has already been set.
> -pub fn init(instance: Arc<dyn ClientFactory + Send + Sync>) {
The module docs should be updated to reflect the removal of this
function, since they now contain a dead reference. I suppose this is now
`context::init()` must have been run.
> - if INSTANCE.set(instance).is_err() {
> - panic!("connection factory instance already set");
> - }
> + context::pdm_application()
> + .client_factory()
> + .make_pbs_client_and_login(remote)
[snip]
next prev parent reply other threads:[~2026-09-03 18:19 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 11:15 [PATCH datacenter-manager/proxmox v5 00/21] inject application context via API macro for easier integration testing Lukas Wagner
2026-09-03 11:15 ` [PATCH proxmox v5 01/21] router: introduce shared state Lukas Wagner
2026-09-03 11:15 ` [PATCH proxmox v5 02/21] rest-server: allow to inject " Lukas Wagner
2026-09-03 11:15 ` [PATCH proxmox v5 03/21] api-macro: support #[state] attribute for state injection Lukas Wagner
2026-09-03 18:51 ` Michael Köppl
2026-09-04 7:19 ` Lukas Wagner
2026-09-03 11:15 ` [PATCH proxmox v5 04/21] product-config: add ProductConfig type Lukas Wagner
2026-09-03 11:15 ` [PATCH datacenter-manager v5 05/21] context: promote context to a dir-style module Lukas Wagner
2026-09-03 11:15 ` [PATCH datacenter-manager v5 06/21] pdm-config: remotes: rename trait methods to read/write/lock Lukas Wagner
2026-09-03 11:15 ` [PATCH datacenter-manager v5 07/21] pdm-config: subscriptions: " Lukas Wagner
2026-09-03 11:15 ` [PATCH datacenter-manager v5 08/21] remote iterator: pass remote config reader explicitly Lukas Wagner
2026-09-03 11:15 ` [PATCH datacenter-manager v5 09/21] context: introduce a ContextFactory to build application context Lukas Wagner
2026-09-03 11:15 ` [PATCH datacenter-manager v5 10/21] context: establish PdmApplication object Lukas Wagner
2026-09-03 11:15 ` [PATCH datacenter-manager v5 11/21] context: register PdmApplication in router Lukas Wagner
2026-09-03 18:19 ` Michael Köppl
2026-09-03 11:16 ` [PATCH datacenter-manager v5 12/21] connection: use client factory from PdmApplication handle Lukas Wagner
2026-09-03 18:19 ` Michael Köppl [this message]
2026-09-04 8:05 ` Lukas Wagner
2026-09-03 11:16 ` [PATCH datacenter-manager v5 13/21] parallel fetcher: pass arguments to closure in a single type Lukas Wagner
2026-09-03 11:16 ` [PATCH datacenter-manager v5 14/21] server: migrate existing ParallelFetcher users to use PdmApplication Lukas Wagner
2026-09-03 11:16 ` [PATCH datacenter-manager v5 15/21] tests: add helpers for building API-handler-level integration tests Lukas Wagner
2026-09-03 11:16 ` [PATCH datacenter-manager v5 16/21] tests: add example tests for SDN API routes Lukas Wagner
2026-09-03 11:16 ` [PATCH datacenter-manager v5 17/21] api-cache: add wrapper type Lukas Wagner
2026-09-03 11:16 ` [PATCH datacenter-manager v5 18/21] context: provide api-cache on the app object Lukas Wagner
2026-09-03 11:16 ` [PATCH datacenter-manager v5 19/21] api: subscriptions: use PdmApplication instead of globals Lukas Wagner
2026-09-03 11:16 ` [PATCH datacenter-manager v5 20/21] pdm-config: subscriptions: drop unused accessor functions Lukas Wagner
2026-09-03 18:19 ` Michael Köppl
2026-09-04 8:07 ` Lukas Wagner
2026-09-03 11:16 ` [PATCH datacenter-manager v5 21/21] tests: add example tests for remote subscription management Lukas Wagner
2026-09-03 18:20 ` [PATCH datacenter-manager/proxmox v5 00/21] inject application context via API macro for easier integration testing Michael Köppl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DL5W0HIN4PJB.3NGWJKFKUX1TJ@proxmox.com \
--to=m.koeppl@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.