From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id A6AD41FF0A5 for ; Fri, 04 Sep 2026 10:07:38 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 742DB21507; Fri, 04 Sep 2026 10:07:38 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 04 Sep 2026 10:07:34 +0200 Message-Id: Subject: Re: [PATCH datacenter-manager v5 20/21] pdm-config: subscriptions: drop unused accessor functions From: "Lukas Wagner" To: =?utf-8?q?Michael_K=C3=B6ppl?= , "Lukas Wagner" , X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260903111609.267762-1-l.wagner@proxmox.com> <20260903111609.267762-21-l.wagner@proxmox.com> In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1788509250604 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.474 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: KN7HJ4ZAJGZU2LK6Y6MTOPN5RLOZO45D X-Message-ID-Hash: KN7HJ4ZAJGZU2LK6Y6MTOPN5RLOZO45D X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu Sep 3, 2026 at 8:19 PM CEST, Michael K=C3=B6ppl wrote: > On Thu Sep 3, 2026 at 1:16 PM CEST, Lukas Wagner wrote: > > [snip] > >> pub trait SubscriptionKeyConfig { >> fn read(&self) -> Result<(SectionConfigData, = ConfigDigest), Error>; >> fn read_shadow(&self) -> Result, Error>; >> @@ -110,9 +77,3 @@ impl SubscriptionKeyConfig for DefaultSubscriptionKey= Config { >> replace_secret_config(SUBSCRIPTIONS_SHADOW_FILENAME, raw.as_byt= es()) >> } >> } >> - >> -pub fn init(instance: Box) { > > Same here regarding the reference in the module docs. It also leaves a > dead reference. > Fixed as well, thanks a lot! Things like these are always easy to overlook for me... >> - if INSTANCE.set(instance).is_err() { >> - panic!("subscription key config instance already set"); >> - } >> -} >> diff --git a/server/src/context/mod.rs b/server/src/context/mod.rs >> index 082ab8de..95238030 100644 >> --- a/server/src/context/mod.rs >> +++ b/server/src/context/mod.rs >> @@ -34,7 +34,6 @@ pub fn init() -> Result { >> // anyway, and the implementation is stateless, so having this seco= nd >> // instance is not an issue *currently*. >> pdm_config::remotes::init(factory.make_remote_config()?); >> - pdm_config::subscriptions::init(factory.make_subscription_key_confi= g()?); >> =20 >> Ok(app) >> }