[PATCH pve-manager] ui: sdn: dns selector: keep an untouched edit dialog clean

[PATCH pve-manager] ui: sdn: dns selector: keep an untouched edit dialog clean

[Hannes Laimer]

The selector starts out on the empty string, and once its store has
loaded an empty selection reads back as null. Both mean that no server
is picked, but the dirty tracking told them apart, so just opening a
zone edit dialog enabled its reset button and let an unchanged form be
submitted.

Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
just noticed here because zone edit kept being marked as dirty, this
could also make sense in ComboGrid directly (don't think we ever
actually differentiate between `null` and `''`?)

 www/manager6/form/SDNDnsSelector.js | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/www/manager6/form/SDNDnsSelector.js b/www/manager6/form/SDNDnsSelector.js
index 7a134541..9d36e8d7 100644
--- a/www/manager6/form/SDNDnsSelector.js
+++ b/www/manager6/form/SDNDnsSelector.js
@@ -8,6 +8,10 @@ Ext.define(
         valueField: 'dns',
         displayField: 'dns',
 
+        isEqual: function (value1, value2) {
+            return String(value1 ?? '') === String(value2 ?? '');
+        },
+
         initComponent: function () {
             var me = this;
 
-- 
2.47.3

Re: [PATCH pve-manager] ui: sdn: dns selector: keep an untouched edit dialog clean

[Elias Huhsovitz]

Gave this a quick test. After applying the patch the "Reset form data"
button is no longer enabled when no changs have been made.

Other selectors such as RouteMapSelector.js resolve this issue by 
explicitly setting

allowBlank: true,
config: {
        value: null,
}

But as far as I understand this might not be optimal here, and chaning
the default value for the selector might have unintended consequences.

IMO changing the value in ComboGrid directly makes sense, should this
arise again. (I also couldn't find a place where we differentiate
between null and an empty string, after a quick search)

Therefore consider this.

Reviewed-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>
Tested-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>

On Thu Aug 6, 2026 at 6:40 PM CEST, Hannes Laimer wrote:
> The selector starts out on the empty string, and once its store has
> loaded an empty selection reads back as null. Both mean that no server
> is picked, but the dirty tracking told them apart, so just opening a
> zone edit dialog enabled its reset button and let an unchanged form be
> submitted.
>
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> just noticed here because zone edit kept being marked as dirty, this
> could also make sense in ComboGrid directly (don't think we ever
> actually differentiate between `null` and `''`?)
>
>  www/manager6/form/SDNDnsSelector.js | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/www/manager6/form/SDNDnsSelector.js b/www/manager6/form/SDNDnsSelector.js
> index 7a134541..9d36e8d7 100644
> --- a/www/manager6/form/SDNDnsSelector.js
> +++ b/www/manager6/form/SDNDnsSelector.js
> @@ -8,6 +8,10 @@ Ext.define(
>          valueField: 'dns',
>          displayField: 'dns',
>  
> +        isEqual: function (value1, value2) {
> +            return String(value1 ?? '') === String(value2 ?? '');
> +        },
> +
>          initComponent: function () {
>              var me = this;
>