From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 007051FF0A7 for ; Tue, 18 Aug 2026 12:49:12 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 39044214DF; Tue, 18 Aug 2026 12:49:10 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 18 Aug 2026 12:49:06 +0200 Message-Id: Subject: Re: [PATCH pve-manager] ui: sdn: dns selector: keep an untouched edit dialog clean From: "Elias Huhsovitz" To: "Hannes Laimer" , X-Mailer: aerc 0.20.0 References: <20260806164001.1901538-1-h.laimer@proxmox.com> In-Reply-To: <20260806164001.1901538-1-h.laimer@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787050125358 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.404 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: VHEWY7YKA23OU4XZGPDJS4FS7XREF2WA X-Message-ID-Hash: VHEWY7YKA23OU4XZGPDJS4FS7XREF2WA X-MailFrom: e.huhsovitz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Gave this a quick test. After applying the patch the "Reset form data" button is no longer enabled when no changs have been made. Other selectors such as RouteMapSelector.js resolve this issue by=20 explicitly setting allowBlank: true, config: { value: null, } But as far as I understand this might not be optimal here, and chaning the default value for the selector might have unintended consequences. IMO changing the value in ComboGrid directly makes sense, should this arise again. (I also couldn't find a place where we differentiate between null and an empty string, after a quick search) Therefore consider this. Reviewed-by: Elias Huhsovitz Tested-by: Elias Huhsovitz On Thu Aug 6, 2026 at 6:40 PM CEST, Hannes Laimer wrote: > The selector starts out on the empty string, and once its store has > loaded an empty selection reads back as null. Both mean that no server > is picked, but the dirty tracking told them apart, so just opening a > zone edit dialog enabled its reset button and let an unchanged form be > submitted. > > Signed-off-by: Hannes Laimer > --- > just noticed here because zone edit kept being marked as dirty, this > could also make sense in ComboGrid directly (don't think we ever > actually differentiate between `null` and `''`?) > > www/manager6/form/SDNDnsSelector.js | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/www/manager6/form/SDNDnsSelector.js b/www/manager6/form/SDND= nsSelector.js > index 7a134541..9d36e8d7 100644 > --- a/www/manager6/form/SDNDnsSelector.js > +++ b/www/manager6/form/SDNDnsSelector.js > @@ -8,6 +8,10 @@ Ext.define( > valueField: 'dns', > displayField: 'dns', > =20 > + isEqual: function (value1, value2) { > + return String(value1 ?? '') =3D=3D=3D String(value2 ?? ''); > + }, > + > initComponent: function () { > var me =3D this; > =20