[PATCH pve-manager 1/1] sdn: wireguard: dont disable name field on creating external node

[PATCH pve-manager 1/1] sdn: wireguard: dont disable name field on creating external node

[Stefan Hanreich]

The logic for disabling the node_id field for external nodes was
wrong, leading to the name field being disable in the node creation
dialog. This prevents users from creating external WireGuard nodes.

Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
 www/manager6/sdn/fabrics/wireguard/NodeEdit.js | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/www/manager6/sdn/fabrics/wireguard/NodeEdit.js b/www/manager6/sdn/fabrics/wireguard/NodeEdit.js
index 69ef85c28..8393ee4a8 100644
--- a/www/manager6/sdn/fabrics/wireguard/NodeEdit.js
+++ b/www/manager6/sdn/fabrics/wireguard/NodeEdit.js
@@ -18,6 +18,12 @@ Ext.define('PVE.sdn.Fabric.WireGuard.Node.Edit', {
                 isPveNode: true,
             },
         },
+        formulas: {
+            disableNameField: function(get) {
+                let me = this;
+                return !me.getView().isCreate || get('current.isPveNode');
+            },
+        }
     },
 
     additionalItems: [
@@ -28,9 +34,7 @@ Ext.define('PVE.sdn.Fabric.WireGuard.Node.Edit', {
             name: 'node_id',
             bind: {
                 hidden: '{current.isPveNode}',
-            },
-            cbind: {
-                disabled: '{!isCreate}',
+                disabled: '{disableNameField}',
             },
             allowBlank: false,
         },
-- 
2.47.3

Re: [PATCH pve-manager 1/1] sdn: wireguard: dont disable name field on creating external node

[Dominik Csapak]

Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>

On 5/15/26 3:50 PM, Stefan Hanreich wrote:
> The logic for disabling the node_id field for external nodes was
> wrong, leading to the name field being disable in the node creation
> dialog. This prevents users from creating external WireGuard nodes.
> 
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
>   www/manager6/sdn/fabrics/wireguard/NodeEdit.js | 10 +++++++---
>   1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/www/manager6/sdn/fabrics/wireguard/NodeEdit.js b/www/manager6/sdn/fabrics/wireguard/NodeEdit.js
> index 69ef85c28..8393ee4a8 100644
> --- a/www/manager6/sdn/fabrics/wireguard/NodeEdit.js
> +++ b/www/manager6/sdn/fabrics/wireguard/NodeEdit.js
> @@ -18,6 +18,12 @@ Ext.define('PVE.sdn.Fabric.WireGuard.Node.Edit', {
>                   isPveNode: true,
>               },
>           },
> +        formulas: {
> +            disableNameField: function(get) {
> +                let me = this;
> +                return !me.getView().isCreate || get('current.isPveNode');
> +            },
> +        }
>       },
>   
>       additionalItems: [
> @@ -28,9 +34,7 @@ Ext.define('PVE.sdn.Fabric.WireGuard.Node.Edit', {
>               name: 'node_id',
>               bind: {
>                   hidden: '{current.isPveNode}',
> -            },
> -            cbind: {
> -                disabled: '{!isCreate}',
> +                disabled: '{disableNameField}',
>               },
>               allowBlank: false,
>           },

Re: [PATCH pve-manager 1/1] sdn: wireguard: dont disable name field on creating external node

[Lukas Sichert]

Tested-by: Lukas Sichert <l.sichert@proxmox.com>

On 2026-05-15 15:50, Stefan Hanreich <s.hanreich@proxmox.com> wrote:

> The logic for disabling the node_id field for external nodes was
> wrong, leading to the name field being disable in the node creation
> dialog. This prevents users from creating external WireGuard nodes.
>
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
>  www/manager6/sdn/fabrics/wireguard/NodeEdit.js | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/www/manager6/sdn/fabrics/wireguard/NodeEdit.js b/www/manager6/sdn/fabrics/wireguard/NodeEdit.js
> index 69ef85c28..8393ee4a8 100644
> --- a/www/manager6/sdn/fabrics/wireguard/NodeEdit.js
> +++ b/www/manager6/sdn/fabrics/wireguard/NodeEdit.js
> @@ -18,6 +18,12 @@ Ext.define('PVE.sdn.Fabric.WireGuard.Node.Edit', {
>                  isPveNode: true,
>              },
>          },
> +        formulas: {
> +            disableNameField: function(get) {
> +                let me = this;
> +                return !me.getView().isCreate || get('current.isPveNode');
> +            },
> +        }
>      },
>  
>      additionalItems: [
> @@ -28,9 +34,7 @@ Ext.define('PVE.sdn.Fabric.WireGuard.Node.Edit', {
>              name: 'node_id',
>              bind: {
>                  hidden: '{current.isPveNode}',
> -            },
> -            cbind: {
> -                disabled: '{!isCreate}',
> +                disabled: '{disableNameField}',
>              },
>              allowBlank: false,
>          },
> -- 
> 2.47.3

Re: [PATCH pve-manager 1/1] sdn: wireguard: dont disable name field on creating external node

[Stefan Hanreich]

On 5/15/26 3:50 PM, Stefan Hanreich wrote:
> The logic for disabling the node_id field for external nodes was
> wrong, leading to the name field being disable in the node creation
> dialog. This prevents users from creating external WireGuard nodes.
> 
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>

FYI this also does not regress the initial reason for changing this,
where the name of external nodes could be edited when editing a node.

applied: [PATCH pve-manager 1/1] sdn: wireguard: dont disable name field on creating external node

[Thomas Lamprecht]

On Fri, 15 May 2026 15:50:01 +0200, Stefan Hanreich wrote:
> The logic for disabling the node_id field for external nodes was
> wrong, leading to the name field being disable in the node creation
> dialog. This prevents users from creating external WireGuard nodes.

Applied, thanks!

[1/1] sdn: wireguard: dont disable name field on creating external node
      commit: 8f8947f664c48a5866685343e8af03009544877e