From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 657491FF14C
	for <inbox@lore.proxmox.com>; Fri, 15 May 2026 16:07:00 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 47220FF17;
	Fri, 15 May 2026 16:06:58 +0200 (CEST)
Message-ID: <78ffc8f7-4dd3-4770-86c1-069b492e2a61@proxmox.com>
Date: Fri, 15 May 2026 16:06:53 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
Subject: Re: [PATCH pve-manager 1/1] sdn: wireguard: dont disable name field
 on creating external node
To: Stefan Hanreich <s.hanreich@proxmox.com>, pve-devel@lists.proxmox.com
References: <20260515135002.351323-1-s.hanreich@proxmox.com>
Content-Language: en-US
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <20260515135002.351323-1-s.hanreich@proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1778854007204
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.050 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: U7SC3R5XUYIY6QFIUQES53444MFLHFMI
X-Message-ID-Hash: U7SC3R5XUYIY6QFIUQES53444MFLHFMI
X-MailFrom: d.csapak@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>

On 5/15/26 3:50 PM, Stefan Hanreich wrote:
> The logic for disabling the node_id field for external nodes was
> wrong, leading to the name field being disable in the node creation
> dialog. This prevents users from creating external WireGuard nodes.
> 
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
>   www/manager6/sdn/fabrics/wireguard/NodeEdit.js | 10 +++++++---
>   1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/www/manager6/sdn/fabrics/wireguard/NodeEdit.js b/www/manager6/sdn/fabrics/wireguard/NodeEdit.js
> index 69ef85c28..8393ee4a8 100644
> --- a/www/manager6/sdn/fabrics/wireguard/NodeEdit.js
> +++ b/www/manager6/sdn/fabrics/wireguard/NodeEdit.js
> @@ -18,6 +18,12 @@ Ext.define('PVE.sdn.Fabric.WireGuard.Node.Edit', {
>                   isPveNode: true,
>               },
>           },
> +        formulas: {
> +            disableNameField: function(get) {
> +                let me = this;
> +                return !me.getView().isCreate || get('current.isPveNode');
> +            },
> +        }
>       },
>   
>       additionalItems: [
> @@ -28,9 +34,7 @@ Ext.define('PVE.sdn.Fabric.WireGuard.Node.Edit', {
>               name: 'node_id',
>               bind: {
>                   hidden: '{current.isPveNode}',
> -            },
> -            cbind: {
> -                disabled: '{!isCreate}',
> +                disabled: '{disableNameField}',
>               },
>               allowBlank: false,
>           },