Re: [PATCH manager v3] ui: ha: add disarm/re-arm button

["Dominik Rusovac" <d.rusovac@proxmox.com>]

thx for taking the time

I will send a v4

On Tue May 12, 2026 at 4:43 AM CEST, Thomas Lamprecht wrote:
> On 16/04/2026 13:19, Dominik Rusovac wrote:
>> The button to disarm HA in either of the resource modes ('freeze' or
>> 'ignore') is disabled as long as HA is disarmed. Analogously, the button
>> to arm HA is disabled as long as HA is not disarmed.
>> 
>> For feedback, after clicking either of the buttons, icon spins as long as
>> (dis)arming process has not changed the armed-state of HA.
>> 
>> The icons ('unlink' and 'link') are chosen to emphasize that "Disarm HA"
>> and "Arm HA" are complements. There may be more suitable pairs of icons
>> though.
>> 
>
> Thanks for this, works OK implementation wise.
>
>> Signed-off-by: Dominik Rusovac <d.rusovac@proxmox.com>
>> ---
>> changes since v2:
>> * inline setting isDisarmed flag
>> * use 'tbar'
>> * switch positions of buttons
>> * hook into 'hastatuschange' to provide feedback via spinning icon while
>>   armed-state of HA changes:
>
> Can we drop that? It's rather confusing, especially as its gone if one
> switches away to another panel and then back to the HA one while disarm
> is still running. And even if one could fix that by checking the status,
> I'd still not mask the whole resources here, seems just a bit odd to do.

sure, I wouldn't mind dropping it

>
> If, then I'd show a spinning icon at the end of the "fencing" status row,
> but not a a must either, I just wanted to put the idea out there as a
> trade to get some feedback for the user.

personally, I don't have a strong opinion on the matter. sounds like a
reasonable compromise to me

>
> In the prompt's I'd find it nice if you could add another sentence for
> what disarming means for each mode.
>
> Like:
>
> "Are you sure you want to disarm HA with resource mode 'Freeze'?
>
> This will freeze all services allowing no change to their operational state."
>
> and:
>
> "Are you sure you want to disarm HA with resource mode 'Ignore'?
>
> This will allow fully circumventing the HA stack for changing the operational state of a service during disarmament."
>
> Maybe throw in that no service will be recovered during HA being disarmed,
> albeit that is IMO a bit more intuitive than the different modes for (newer) users.

ok will do