all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dominik Rusovac <d.rusovac@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH manager v3] ui: ha: add disarm/re-arm button
Date: Tue, 12 May 2026 04:43:39 +0200	[thread overview]
Message-ID: <6b5873a4-2347-4d9b-b884-fb22773ba800@proxmox.com> (raw)
In-Reply-To: <20260416112033.148589-1-d.rusovac@proxmox.com>

On 16/04/2026 13:19, Dominik Rusovac wrote:
> The button to disarm HA in either of the resource modes ('freeze' or
> 'ignore') is disabled as long as HA is disarmed. Analogously, the button
> to arm HA is disabled as long as HA is not disarmed.
> 
> For feedback, after clicking either of the buttons, icon spins as long as
> (dis)arming process has not changed the armed-state of HA.
> 
> The icons ('unlink' and 'link') are chosen to emphasize that "Disarm HA"
> and "Arm HA" are complements. There may be more suitable pairs of icons
> though.
> 

Thanks for this, works OK implementation wise.

> Signed-off-by: Dominik Rusovac <d.rusovac@proxmox.com>
> ---
> changes since v2:
> * inline setting isDisarmed flag
> * use 'tbar'
> * switch positions of buttons
> * hook into 'hastatuschange' to provide feedback via spinning icon while
>   armed-state of HA changes:

Can we drop that? It's rather confusing, especially as its gone if one
switches away to another panel and then back to the HA one while disarm
is still running. And even if one could fix that by checking the status,
I'd still not mask the whole resources here, seems just a bit odd to do.

If, then I'd show a spinning icon at the end of the "fencing" status row,
but not a a must either, I just wanted to put the idea out there as a
trade to get some feedback for the user.

In the prompt's I'd find it nice if you could add another sentence for
what disarming means for each mode.

Like:

"Are you sure you want to disarm HA with resource mode 'Freeze'?

This will freeze all services allowing no change to their operational state."

and:

"Are you sure you want to disarm HA with resource mode 'Ignore'?

This will allow fully circumventing the HA stack for changing the operational state of a service during disarmament."

Maybe throw in that no service will be recovered during HA being disarmed,
albeit that is IMO a bit more intuitive than the different modes for (newer) users.





  reply	other threads:[~2026-05-12  2:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-16 11:20 [PATCH manager v3] ui: ha: add disarm/re-arm button Dominik Rusovac
2026-05-12  2:43 ` Thomas Lamprecht [this message]
2026-05-12  6:58   ` Dominik Rusovac
2026-05-13  8:15 ` Dominik Rusovac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6b5873a4-2347-4d9b-b884-fb22773ba800@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.rusovac@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal