From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 61A971FF146 for ; Tue, 12 May 2026 08:58:33 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 048735622; Tue, 12 May 2026 08:58:31 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 12 May 2026 08:58:26 +0200 Message-Id: Subject: Re: [PATCH manager v3] ui: ha: add disarm/re-arm button From: "Dominik Rusovac" To: "Thomas Lamprecht" , X-Mailer: aerc 0.20.0 References: <20260416112033.148589-1-d.rusovac@proxmox.com> <6b5873a4-2347-4d9b-b884-fb22773ba800@proxmox.com> In-Reply-To: <6b5873a4-2347-4d9b-b884-fb22773ba800@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778568994293 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.361 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GL35QH27UZTRUJTWJLA5DJNOL77NBWIL X-Message-ID-Hash: GL35QH27UZTRUJTWJLA5DJNOL77NBWIL X-MailFrom: d.rusovac@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: thx for taking the time I will send a v4 On Tue May 12, 2026 at 4:43 AM CEST, Thomas Lamprecht wrote: > On 16/04/2026 13:19, Dominik Rusovac wrote: >> The button to disarm HA in either of the resource modes ('freeze' or >> 'ignore') is disabled as long as HA is disarmed. Analogously, the button >> to arm HA is disabled as long as HA is not disarmed. >>=20 >> For feedback, after clicking either of the buttons, icon spins as long a= s >> (dis)arming process has not changed the armed-state of HA. >>=20 >> The icons ('unlink' and 'link') are chosen to emphasize that "Disarm HA" >> and "Arm HA" are complements. There may be more suitable pairs of icons >> though. >>=20 > > Thanks for this, works OK implementation wise. > >> Signed-off-by: Dominik Rusovac >> --- >> changes since v2: >> * inline setting isDisarmed flag >> * use 'tbar' >> * switch positions of buttons >> * hook into 'hastatuschange' to provide feedback via spinning icon while >> armed-state of HA changes: > > Can we drop that? It's rather confusing, especially as its gone if one > switches away to another panel and then back to the HA one while disarm > is still running. And even if one could fix that by checking the status, > I'd still not mask the whole resources here, seems just a bit odd to do. sure, I wouldn't mind dropping it > > If, then I'd show a spinning icon at the end of the "fencing" status row, > but not a a must either, I just wanted to put the idea out there as a > trade to get some feedback for the user. personally, I don't have a strong opinion on the matter. sounds like a reasonable compromise to me > > In the prompt's I'd find it nice if you could add another sentence for > what disarming means for each mode. > > Like: > > "Are you sure you want to disarm HA with resource mode 'Freeze'? > > This will freeze all services allowing no change to their operational sta= te." > > and: > > "Are you sure you want to disarm HA with resource mode 'Ignore'? > > This will allow fully circumventing the HA stack for changing the operati= onal state of a service during disarmament." > > Maybe throw in that no service will be recovered during HA being disarmed= , > albeit that is IMO a bit more intuitive than the different modes for (new= er) users. ok will do