Re: [PATCH cluster 1/5] add functions to determine warning level for high token timeouts

["Michael Köppl" <m.koeppl@proxmox.com>]

On Mon Apr 20, 2026 at 11:39 AM CEST, Friedrich Weber wrote:
> On 20/04/2026 10:26, Michael Köppl wrote:
>> On Fri Apr 17, 2026 at 10:33 AM CEST, Friedrich Weber wrote:
>> 
>> [snip]
>> 
>>>>
>>>> +sub calculate_total_timeout {
>>>
>>> I think "total timeout" is a little too vague, especially because it's
>>> also user-facing. I don't think totem/corosync have a term for "sum of
>>> token and consensus timeout", and "sum of token and consensus timeout"
>>> is a too long. Perhaps something like "recovery timeout" -- though not
>>> perfect because "Recovery" is a specific state in the totem state
>>> machine. Maybe "membership convergence timeout" (though that's a bit
>>> long and obscure)?
>> 
>> Thanks for having a look at this and for your feedback. I agree that the
>> naming is a bit too vague, though I really wasn't sure what else to name
>> it. I think calculate_membership_convergence_timeout could work. As an
>> alternative suggestion, what do you think of
>> calculate_cluster_reformation_timeout? Of course that's also a more
>> "verbose" name, but I think it describes the effects of the timeout
>> quite well.
>
> Hm, "Reformation" reads a bit weird to me. Perhaps "recovery" is not so
> bad after all (a bit less esoteric than convergence or reformation),
> what about "membership recovery timeout"? The "membership" qualifier
> should make it reasonably clear that it's not the same as totem's
> "recovery" state.

I'll go with calculate_membership_recovery_timeout then. I think it
makes it a lot clearer what this timeout actually is. Thanks!