Re: [PATCH cluster 1/5] add functions to determine warning level for high token timeouts

["Michael Köppl" <m.koeppl@proxmox.com>]

On Fri Apr 17, 2026 at 10:33 AM CEST, Friedrich Weber wrote:

[snip]

>>
>> +sub calculate_total_timeout {
>
> I think "total timeout" is a little too vague, especially because it's
> also user-facing. I don't think totem/corosync have a term for "sum of
> token and consensus timeout", and "sum of token and consensus timeout"
> is a too long. Perhaps something like "recovery timeout" -- though not
> perfect because "Recovery" is a specific state in the totem state
> machine. Maybe "membership convergence timeout" (though that's a bit
> long and obscure)?

Thanks for having a look at this and for your feedback. I agree that the
naming is a bit too vague, though I really wasn't sure what else to name
it. I think calculate_membership_convergence_timeout could work. As an
alternative suggestion, what do you think of
calculate_cluster_reformation_timeout? Of course that's also a more
"verbose" name, but I think it describes the effects of the timeout
quite well.

>
>> +    my ($totemcfg, $node_count) = @_;
>> +
>> +    my $token_timeout = $totemcfg->{token} // 3000;
>> +    my $token_coefficient = $totemcfg->{token_coefficient} // 650;
>> +
>> +    my $expected_token_timeout = $token_timeout;
>> +    if ($node_count > 2) {
>> +        $expected_token_timeout += ($node_count - 2) * $token_coefficient;
>> +    }
>> +
>> +    my $expected_consensus_timeout = $totemcfg->{consensus} // $expected_token_timeout * 1.2;
>> +    return ($expected_token_timeout + $expected_consensus_timeout) / 1000.0;
>> +}
>> +
>> +sub get_timeout_warning_level {
>> +    my ($total_timeout_secs) = @_;
>> +
>> +    if ($total_timeout_secs > 50) {
>> +        return 'change-strongly-recommended';
>
> I realize I'm the source of these numbers :) But since >50 is actually
> pretty bad already, if we phrase it as "strongly recommended" we can
> probably go for a slightly lower number:
>
> - > 45: change-strongly-recommended
> - > 40: change recommended
> - > 30: optimize

will lower them for a v2, thanks! :) I'd already wondered about the
thresholds when I implemented this, but thought it'd make sense to start
with the values from the bugzilla.

>
>> +    } elsif ($total_timeout_secs > 40) {
>> +        return 'change-recommended';

[snip]