Re: [PATCH cluster 2/5] pvecm: warn users of high token timeouts when using nodes command

[Friedrich Weber <f.weber@proxmox.com>]

On 30/03/2026 16:47, Michael Köppl wrote:
> If the calculated token timeout is above certain thresholds, display a
> warning for users when running `pvecm nodes`. Also points users to the
> documentation regarding potential adaptations to their cluster
> configuration to alleviate the problem.
> 
> Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
> ---
>  src/PVE/CLI/pvecm.pm | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/src/PVE/CLI/pvecm.pm b/src/PVE/CLI/pvecm.pm
> index 7d393a8..561c5f6 100755
> --- a/src/PVE/CLI/pvecm.pm
> +++ b/src/PVE/CLI/pvecm.pm
> @@ -584,6 +584,15 @@ __PACKAGE__->register_method({
>  
>          PVE::Corosync::check_conf_exists();
>  
> +        my $conf = PVE::Cluster::cfs_read_file("corosync.conf");
> +        my $nodelist = PVE::Corosync::nodelist($conf);
> +        my $totem_cfg = PVE::Corosync::totem_config($conf);
> +        my $total_timeout_secs =
> +            PVE::Corosync::calculate_total_timeout($totem_cfg, scalar(keys %$nodelist));
> +        if (my $msg = PVE::Corosync::get_timeout_warning($total_timeout_secs)) {
> +            warn "$msg\n";
> +        }
> +

I can see why 'pvecm nodes' was chosen for this warning (since it's
related to the number of nodes), but I think 'pvecm status' would be
more appropriate, because it relates to the cluster health (perhaps
under 'Cluster Information')? We could also do both, but that's probably
overkill.

>          exec('corosync-quorumtool', '-l');
>          exit(-1); # should not be reached
>      },