From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 647941FF13E for ; Fri, 17 Apr 2026 10:33:18 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DF64A1970E; Fri, 17 Apr 2026 10:33:17 +0200 (CEST) Message-ID: Date: Fri, 17 Apr 2026 10:33:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH cluster 2/5] pvecm: warn users of high token timeouts when using nodes command To: =?UTF-8?Q?Michael_K=C3=B6ppl?= , pve-devel@lists.proxmox.com References: <20260330144321.321072-1-m.koeppl@proxmox.com> <20260330144321.321072-3-m.koeppl@proxmox.com> Content-Language: en-US From: Friedrich Weber In-Reply-To: <20260330144321.321072-3-m.koeppl@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776414715021 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.011 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: QPITD7BTZVEUL2D6CKJ443JQNQKPTX56 X-Message-ID-Hash: QPITD7BTZVEUL2D6CKJ443JQNQKPTX56 X-MailFrom: f.weber@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 30/03/2026 16:47, Michael Köppl wrote: > If the calculated token timeout is above certain thresholds, display a > warning for users when running `pvecm nodes`. Also points users to the > documentation regarding potential adaptations to their cluster > configuration to alleviate the problem. > > Signed-off-by: Michael Köppl > --- > src/PVE/CLI/pvecm.pm | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/src/PVE/CLI/pvecm.pm b/src/PVE/CLI/pvecm.pm > index 7d393a8..561c5f6 100755 > --- a/src/PVE/CLI/pvecm.pm > +++ b/src/PVE/CLI/pvecm.pm > @@ -584,6 +584,15 @@ __PACKAGE__->register_method({ > > PVE::Corosync::check_conf_exists(); > > + my $conf = PVE::Cluster::cfs_read_file("corosync.conf"); > + my $nodelist = PVE::Corosync::nodelist($conf); > + my $totem_cfg = PVE::Corosync::totem_config($conf); > + my $total_timeout_secs = > + PVE::Corosync::calculate_total_timeout($totem_cfg, scalar(keys %$nodelist)); > + if (my $msg = PVE::Corosync::get_timeout_warning($total_timeout_secs)) { > + warn "$msg\n"; > + } > + I can see why 'pvecm nodes' was chosen for this warning (since it's related to the number of nodes), but I think 'pvecm status' would be more appropriate, because it relates to the cluster health (perhaps under 'Cluster Information')? We could also do both, but that's probably overkill. > exec('corosync-quorumtool', '-l'); > exit(-1); # should not be reached > },