all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Michael Köppl" <m.koeppl@proxmox.com>
To: "Daniel Kral" <d.kral@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH-SERIES manager/docs 00/18] crs docs updates + load balancer ui and docs followup
Date: Mon, 13 Apr 2026 18:11:45 +0200	[thread overview]
Message-ID: <DHS5QIDIMZ0I.3E63PFS7R6MVH@proxmox.com> (raw)
In-Reply-To: <20260409114224.323102-1-d.kral@proxmox.com>

Tested this on my local 3-node cluster. Played around a bit with the
various settings in the UI, checking if they are set and applied
correctly in the config. Did not notice anything off except a small
cosmetic issue that I noted in a comment on the individual patch. Also
went through the docs updates, but only noticed a few typos which I also
mentioned in comments to the individual patches. Nice work!

Consider this:

Reviewed-by: Michael Köppl <m.koeppl@proxmox.com>
Tested-by: Michael Köppl <m.koeppl@proxmox.com>

On Thu Apr 9, 2026 at 1:41 PM CEST, Daniel Kral wrote:
> A followup to the static/dynamic load balancer series [0], which
> includes the documentation and smaller UI improvements for configuring
> the load balancer.
>
> These patches also clean up the already existing CRS section and updates
> it according to the other recent changes, such as:
>
> - s/HA service/HA resource/ to avoid mixed usage of both terms in the
>   same section
> - basic/static-load scheduler mode include non-HA resources as well now
> - the dynamic load scheduler is added now
> - the dynamic load scheduler mode shares the behavior on
>   rebalance-on-start now, moving this to its own section
> - there's a section for the load balancer with some motivational text as
>   well as some details about the configuration options
> - update the crs datacenter gui screenshot accordingly
>
> The UI patches fix some oversights that came up while writing the
> documentation:
>
> - add missing 'edit' subject in new crs modal
> - s/HA service/HA resource/ to avoid mixed usage of both terms
> - s/HA Scheduling/Scheduler Mode/ as it's referred so in the docs
> - constrain users to only enable and set load balancer options if either
>   'static' or 'dynamic' scheduler mode is set
>
> I've marked the load balancer feature as technology preview now, to
> hopefully get enough user feedback (and the according improvements) in
> for a stable release for Proxmox VE 9.2. I'll leave this bit at the
> discretion of the applying maintainer.
>
> I'd be happy to have some feedback on the changes!
>
> [0] https://lore.proxmox.com/pve-devel/20260402124817.416232-1-d.kral@proxmox.com/
>
>
> manager:
>
> Daniel Kral (5):
>   ui: form/CRSOptions: add missing edit modal title
>   ui: form/CRSOptions: rename HA Scheduling to Scheduling Mode
>   ui: form/CRSOptions: replace HA service term with HA resource
>   ui: form/CRSOptions: use view model for auto rebalancing option
>   ui: form/CRSOptions: allow auto rebalancing only for static and
>     dynamic mode
>
>  www/manager6/form/CRSOptions.js | 37 +++++++++++++++++++++++----------
>  1 file changed, 26 insertions(+), 11 deletions(-)
>
>
> docs:
>
> Daniel Kral (13):
>   ha-manager: crs: replace service term with HA resource
>   ha-manager: crs: remove note about manual changes to datacenter config
>   ha-manager: crs: improve introduction
>   ha-manager: crs: introduce crs scheduling mode section
>   ha-manager: crs: generalize the description for basic and static load
>     modes
>   ha-manager: crs: remove HA group config from scheduling points list
>   ha-manager: crs: use headings for the scheduling points
>   ha-manager: crs: reword the rebalance on start scheduling point
>   ha-manager: crs: add more information about rebalance on start in its
>     section
>   ha-manager: crs: change crs modes to include all active guests
>   ha-manager: crs: add dynamic load scheduler
>   screenshots: update crs datacenter options screenshot
>   ha-manager: crs: add load balancer section
>
>  ha-manager.adoc                               | 206 ++++++++++++------
>  .../screenshot/gui-datacenter-options-crs.png | Bin 16395 -> 34280 bytes
>  2 files changed, 134 insertions(+), 72 deletions(-)
>
>
> Summary over all repositories:
>   3 files changed, 160 insertions(+), 83 deletions(-)





  parent reply	other threads:[~2026-04-13 16:11 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-09 11:41 Daniel Kral
2026-04-09 11:41 ` [PATCH manager 01/18] ui: form/CRSOptions: add missing edit modal title Daniel Kral
2026-04-09 11:41 ` [PATCH manager 02/18] ui: form/CRSOptions: rename HA Scheduling to Scheduling Mode Daniel Kral
2026-04-09 11:41 ` [PATCH manager 03/18] ui: form/CRSOptions: replace HA service term with HA resource Daniel Kral
2026-04-09 11:41 ` [PATCH manager 04/18] ui: form/CRSOptions: use view model for auto rebalancing option Daniel Kral
2026-04-09 11:41 ` [PATCH manager 05/18] ui: form/CRSOptions: allow auto rebalancing only for static and dynamic mode Daniel Kral
2026-04-13 16:01   ` Michael Köppl
2026-04-14  7:18     ` Daniel Kral
2026-04-14  7:32       ` Michael Köppl
2026-04-14  7:39         ` Daniel Kral
2026-04-09 11:41 ` [PATCH docs 06/18] ha-manager: crs: replace service term with HA resource Daniel Kral
2026-04-09 11:41 ` [PATCH docs 07/18] ha-manager: crs: remove note about manual changes to datacenter config Daniel Kral
2026-04-10  8:17   ` Shannon Sterz
2026-04-10 11:18     ` Daniel Kral
2026-04-10 11:37       ` Shannon Sterz
2026-04-09 11:41 ` [PATCH docs 08/18] ha-manager: crs: improve introduction Daniel Kral
2026-04-09 11:41 ` [PATCH docs 09/18] ha-manager: crs: introduce crs scheduling mode section Daniel Kral
2026-04-09 11:41 ` [PATCH docs 10/18] ha-manager: crs: generalize the description for basic and static load modes Daniel Kral
2026-04-09 11:41 ` [PATCH docs 11/18] ha-manager: crs: remove HA group config from scheduling points list Daniel Kral
2026-04-09 11:41 ` [PATCH docs 12/18] ha-manager: crs: use headings for the scheduling points Daniel Kral
2026-04-13 15:52   ` Michael Köppl
2026-04-09 11:41 ` [PATCH docs 13/18] ha-manager: crs: reword the rebalance on start scheduling point Daniel Kral
2026-04-13 15:53   ` Michael Köppl
2026-04-09 11:41 ` [PATCH docs 14/18] ha-manager: crs: add more information about rebalance on start in its section Daniel Kral
2026-04-09 11:41 ` [PATCH docs 15/18] ha-manager: crs: change crs modes to include all active guests Daniel Kral
2026-04-09 11:41 ` [PATCH docs 16/18] ha-manager: crs: add dynamic load scheduler Daniel Kral
2026-04-09 11:41 ` [PATCH docs 17/18] screenshots: update crs datacenter options screenshot Daniel Kral
2026-04-09 11:41 ` [PATCH docs 18/18] ha-manager: crs: add load balancer section Daniel Kral
2026-04-13 16:11   ` Michael Köppl
2026-04-14 12:03   ` Dominik Rusovac
2026-04-13 16:11 ` Michael Köppl [this message]
2026-04-14  7:24   ` [PATCH-SERIES manager/docs 00/18] crs docs updates + load balancer ui and docs followup Daniel Kral
2026-04-15  9:19 ` superseded: " Daniel Kral

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DHS5QIDIMZ0I.3E63PFS7R6MVH@proxmox.com \
    --to=m.koeppl@proxmox.com \
    --cc=d.kral@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal