From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 2606B1FF291 for ; Mon, 13 Apr 2026 18:11:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EF30747FF; Mon, 13 Apr 2026 18:11:49 +0200 (CEST) Content-Type: text/plain; charset=UTF-8 Date: Mon, 13 Apr 2026 18:11:45 +0200 Message-Id: To: "Daniel Kral" , Subject: Re: [PATCH-SERIES manager/docs 00/18] crs docs updates + load balancer ui and docs followup From: =?utf-8?q?Michael_K=C3=B6ppl?= Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: aerc 0.21.0 References: <20260409114224.323102-1-d.kral@proxmox.com> In-Reply-To: <20260409114224.323102-1-d.kral@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776096630852 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.101 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Message-ID-Hash: NEKCH4HYSBZE5YHVMNR53CLLJTTH3DIR X-Message-ID-Hash: NEKCH4HYSBZE5YHVMNR53CLLJTTH3DIR X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Tested this on my local 3-node cluster. Played around a bit with the various settings in the UI, checking if they are set and applied correctly in the config. Did not notice anything off except a small cosmetic issue that I noted in a comment on the individual patch. Also went through the docs updates, but only noticed a few typos which I also mentioned in comments to the individual patches. Nice work! Consider this: Reviewed-by: Michael K=C3=B6ppl Tested-by: Michael K=C3=B6ppl On Thu Apr 9, 2026 at 1:41 PM CEST, Daniel Kral wrote: > A followup to the static/dynamic load balancer series [0], which > includes the documentation and smaller UI improvements for configuring > the load balancer. > > These patches also clean up the already existing CRS section and updates > it according to the other recent changes, such as: > > - s/HA service/HA resource/ to avoid mixed usage of both terms in the > same section > - basic/static-load scheduler mode include non-HA resources as well now > - the dynamic load scheduler is added now > - the dynamic load scheduler mode shares the behavior on > rebalance-on-start now, moving this to its own section > - there's a section for the load balancer with some motivational text as > well as some details about the configuration options > - update the crs datacenter gui screenshot accordingly > > The UI patches fix some oversights that came up while writing the > documentation: > > - add missing 'edit' subject in new crs modal > - s/HA service/HA resource/ to avoid mixed usage of both terms > - s/HA Scheduling/Scheduler Mode/ as it's referred so in the docs > - constrain users to only enable and set load balancer options if either > 'static' or 'dynamic' scheduler mode is set > > I've marked the load balancer feature as technology preview now, to > hopefully get enough user feedback (and the according improvements) in > for a stable release for Proxmox VE 9.2. I'll leave this bit at the > discretion of the applying maintainer. > > I'd be happy to have some feedback on the changes! > > [0] https://lore.proxmox.com/pve-devel/20260402124817.416232-1-d.kral@pro= xmox.com/ > > > manager: > > Daniel Kral (5): > ui: form/CRSOptions: add missing edit modal title > ui: form/CRSOptions: rename HA Scheduling to Scheduling Mode > ui: form/CRSOptions: replace HA service term with HA resource > ui: form/CRSOptions: use view model for auto rebalancing option > ui: form/CRSOptions: allow auto rebalancing only for static and > dynamic mode > > www/manager6/form/CRSOptions.js | 37 +++++++++++++++++++++++---------- > 1 file changed, 26 insertions(+), 11 deletions(-) > > > docs: > > Daniel Kral (13): > ha-manager: crs: replace service term with HA resource > ha-manager: crs: remove note about manual changes to datacenter config > ha-manager: crs: improve introduction > ha-manager: crs: introduce crs scheduling mode section > ha-manager: crs: generalize the description for basic and static load > modes > ha-manager: crs: remove HA group config from scheduling points list > ha-manager: crs: use headings for the scheduling points > ha-manager: crs: reword the rebalance on start scheduling point > ha-manager: crs: add more information about rebalance on start in its > section > ha-manager: crs: change crs modes to include all active guests > ha-manager: crs: add dynamic load scheduler > screenshots: update crs datacenter options screenshot > ha-manager: crs: add load balancer section > > ha-manager.adoc | 206 ++++++++++++------ > .../screenshot/gui-datacenter-options-crs.png | Bin 16395 -> 34280 bytes > 2 files changed, 134 insertions(+), 72 deletions(-) > > > Summary over all repositories: > 3 files changed, 160 insertions(+), 83 deletions(-)