From: "Daniel Kral" <d.kral@proxmox.com>
To: "Michael Köppl" <m.koeppl@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH-SERIES manager/docs 00/18] crs docs updates + load balancer ui and docs followup
Date: Tue, 14 Apr 2026 09:24:18 +0200 [thread overview]
Message-ID: <DHSP57NYG25H.1W6VE8P5CAI5Q@proxmox.com> (raw)
In-Reply-To: <DHS5QIDIMZ0I.3E63PFS7R6MVH@proxmox.com>
On Mon Apr 13, 2026 at 6:11 PM CEST, Michael Köppl wrote:
> Tested this on my local 3-node cluster. Played around a bit with the
> various settings in the UI, checking if they are set and applied
> correctly in the config. Did not notice anything off except a small
> cosmetic issue that I noted in a comment on the individual patch. Also
> went through the docs updates, but only noticed a few typos which I also
> mentioned in comments to the individual patches. Nice work!
>
> Consider this:
>
> Reviewed-by: Michael Köppl <m.koeppl@proxmox.com>
> Tested-by: Michael Köppl <m.koeppl@proxmox.com>
Thanks a lot for the review!
Besides the cosmetic UI issue where I'm unsure how to best handle that,
I'll integrate the feedback to the docs for the v2!
next prev parent reply other threads:[~2026-04-14 7:24 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 11:41 Daniel Kral
2026-04-09 11:41 ` [PATCH manager 01/18] ui: form/CRSOptions: add missing edit modal title Daniel Kral
2026-04-09 11:41 ` [PATCH manager 02/18] ui: form/CRSOptions: rename HA Scheduling to Scheduling Mode Daniel Kral
2026-04-09 11:41 ` [PATCH manager 03/18] ui: form/CRSOptions: replace HA service term with HA resource Daniel Kral
2026-04-09 11:41 ` [PATCH manager 04/18] ui: form/CRSOptions: use view model for auto rebalancing option Daniel Kral
2026-04-09 11:41 ` [PATCH manager 05/18] ui: form/CRSOptions: allow auto rebalancing only for static and dynamic mode Daniel Kral
2026-04-13 16:01 ` Michael Köppl
2026-04-14 7:18 ` Daniel Kral
2026-04-14 7:32 ` Michael Köppl
2026-04-14 7:39 ` Daniel Kral
2026-04-09 11:41 ` [PATCH docs 06/18] ha-manager: crs: replace service term with HA resource Daniel Kral
2026-04-09 11:41 ` [PATCH docs 07/18] ha-manager: crs: remove note about manual changes to datacenter config Daniel Kral
2026-04-10 8:17 ` Shannon Sterz
2026-04-10 11:18 ` Daniel Kral
2026-04-10 11:37 ` Shannon Sterz
2026-04-09 11:41 ` [PATCH docs 08/18] ha-manager: crs: improve introduction Daniel Kral
2026-04-09 11:41 ` [PATCH docs 09/18] ha-manager: crs: introduce crs scheduling mode section Daniel Kral
2026-04-09 11:41 ` [PATCH docs 10/18] ha-manager: crs: generalize the description for basic and static load modes Daniel Kral
2026-04-09 11:41 ` [PATCH docs 11/18] ha-manager: crs: remove HA group config from scheduling points list Daniel Kral
2026-04-09 11:41 ` [PATCH docs 12/18] ha-manager: crs: use headings for the scheduling points Daniel Kral
2026-04-13 15:52 ` Michael Köppl
2026-04-09 11:41 ` [PATCH docs 13/18] ha-manager: crs: reword the rebalance on start scheduling point Daniel Kral
2026-04-13 15:53 ` Michael Köppl
2026-04-09 11:41 ` [PATCH docs 14/18] ha-manager: crs: add more information about rebalance on start in its section Daniel Kral
2026-04-09 11:41 ` [PATCH docs 15/18] ha-manager: crs: change crs modes to include all active guests Daniel Kral
2026-04-09 11:41 ` [PATCH docs 16/18] ha-manager: crs: add dynamic load scheduler Daniel Kral
2026-04-09 11:41 ` [PATCH docs 17/18] screenshots: update crs datacenter options screenshot Daniel Kral
2026-04-09 11:41 ` [PATCH docs 18/18] ha-manager: crs: add load balancer section Daniel Kral
2026-04-13 16:11 ` Michael Köppl
2026-04-14 12:03 ` Dominik Rusovac
2026-04-13 16:11 ` [PATCH-SERIES manager/docs 00/18] crs docs updates + load balancer ui and docs followup Michael Köppl
2026-04-14 7:24 ` Daniel Kral [this message]
2026-04-15 9:19 ` superseded: " Daniel Kral
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DHSP57NYG25H.1W6VE8P5CAI5Q@proxmox.com \
--to=d.kral@proxmox.com \
--cc=m.koeppl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.