* [PATCH acme] acme: fix USER_AGENT variable interpolation in curl calls
@ 2026-08-06 15:04 Aaron Carson
2026-08-12 12:09 ` superseded: " Aaron Carson
0 siblings, 1 reply; 2+ messages in thread
From: Aaron Carson @ 2026-08-06 15:04 UTC (permalink / raw)
To: pve-devel; +Cc: Aaron Carson
Signed-off-by: Aaron Carson <aaron@aaroncarson.co.uk>
---
Hi folks, just a small fix - noticed that the user agent being seen by
my DNS server was literally USER_AGENT when updating DNS for ACME. I
know the contribution guide says to discuss before sending in a patch -
but for a two character fix, thought that was unnecessary. Apologies if
not though. Thanks!
src/proxmox-acme | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/proxmox-acme b/src/proxmox-acme
index 705f7df..39c770b 100644
--- a/src/proxmox-acme
+++ b/src/proxmox-acme
@@ -348,9 +348,9 @@ _get_impl() {
_CURL="$_CURL --connect-timeout $t"
fi
if [ "$onlyheader" ]; then
- $_CURL -I --user-agent "USER_AGENT" -H "$_H1" -H "$_H2" -H "$_H3" -H "$_H4" -H "$_H5" "$url"
+ $_CURL -I --user-agent "$USER_AGENT" -H "$_H1" -H "$_H2" -H "$_H3" -H "$_H4" -H "$_H5" "$url"
else
- $_CURL --user-agent "USER_AGENT" -H "$_H1" -H "$_H2" -H "$_H3" -H "$_H4" -H "$_H5" "$url"
+ $_CURL --user-agent "$USER_AGENT" -H "$_H1" -H "$_H2" -H "$_H3" -H "$_H4" -H "$_H5" "$url"
fi
ret=$?
if [ "$ret" != "0" ]; then
--
2.52.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* superseded: [PATCH acme] acme: fix USER_AGENT variable interpolation in curl calls
2026-08-06 15:04 [PATCH acme] acme: fix USER_AGENT variable interpolation in curl calls Aaron Carson
@ 2026-08-12 12:09 ` Aaron Carson
0 siblings, 0 replies; 2+ messages in thread
From: Aaron Carson @ 2026-08-12 12:09 UTC (permalink / raw)
To: pve-devel
https://lore.proxmox.com/pve-devel/20260812120711.3626458-1-aaron@aaroncarson.co.uk/T/#u
On Thu, 6 Aug 2026 at 16:05, Aaron Carson <aaron@aaroncarson.co.uk> wrote:
> Signed-off-by: Aaron Carson <aaron@aaroncarson.co.uk>
> ---
> Hi folks, just a small fix - noticed that the user agent being seen by
> my DNS server was literally USER_AGENT when updating DNS for ACME. I
> know the contribution guide says to discuss before sending in a patch -
> but for a two character fix, thought that was unnecessary. Apologies if
> not though. Thanks!
>
> src/proxmox-acme | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/proxmox-acme b/src/proxmox-acme
> index 705f7df..39c770b 100644
> --- a/src/proxmox-acme
> +++ b/src/proxmox-acme
> @@ -348,9 +348,9 @@ _get_impl() {
> _CURL="$_CURL --connect-timeout $t"
> fi
> if [ "$onlyheader" ]; then
> - $_CURL -I --user-agent "USER_AGENT" -H "$_H1" -H "$_H2" -H "$_H3" -H
> "$_H4" -H "$_H5" "$url"
> + $_CURL -I --user-agent "$USER_AGENT" -H "$_H1" -H "$_H2" -H "$_H3" -H
> "$_H4" -H "$_H5" "$url"
> else
> - $_CURL --user-agent "USER_AGENT" -H "$_H1" -H "$_H2" -H "$_H3" -H
> "$_H4" -H "$_H5" "$url"
> + $_CURL --user-agent "$USER_AGENT" -H "$_H1" -H "$_H2" -H "$_H3" -H
> "$_H4" -H "$_H5" "$url"
> fi
> ret=$?
> if [ "$ret" != "0" ]; then
> --
> 2.52.0
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-12 12:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-06 15:04 [PATCH acme] acme: fix USER_AGENT variable interpolation in curl calls Aaron Carson
2026-08-12 12:09 ` superseded: " Aaron Carson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.