From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 8BC481FF129 for ; Thu, 06 Aug 2026 17:06:07 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 404592153C; Thu, 06 Aug 2026 17:06:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aaroncarson.co.uk; s=google; t=1786028756; x=1786633556; darn=lists.proxmox.com; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ybMju/Dz/ufioRzT3asZRckLrbBZZdfl5jeXhK71X8U=; b=flUKLntoO9uc3VjmHgoK+Mv9flGC87kjE4Hv0kkYruM7wsAJfGMQgd8qYyn0OueIbI yQLfTQkHvq2YFFUYSIkbgNryHcbSfSM1GopxmzleAvRHmdiHZL27nezVPAm3r/HGKiMn cGHbZTmq8PajAUWWiM07Y9soUzHdtAC4nsfYdzU1XbznRmXbP+S2U0px1oJygY/w1RgZ MLrtK2/mup2GeVf6NL/MaN6vsHymKxaEqzxtLyHUA+yOHsaY1BuNmb5+40AO159hN7wZ B8sOcFsXvoscwbutvlbtkveRIuiXG2ZHlXGQ2PjgdeFJMmnPWk9RHI1KPISzOtCEWPgo jhMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786028756; x=1786633556; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ybMju/Dz/ufioRzT3asZRckLrbBZZdfl5jeXhK71X8U=; b=qBA83PbHa4zj3x755vUbaLCZQvL7GadtPC8su0D1X2f6r6SSsrQP0fJOy6Yb3vvBkp jQT7R3qu7jtOYu5NJoYDma9bGJqPvPqjJ1/2kuT2/4hfVOkPbbTvNVfLu143Tdopcciq hWoC3X894xGAgU66qwnn61BNlQh+FaOzMOGaOaAkEsx/0fZzqzPJ/WM/THU5Awf4s+Wy 8bwvzGSYMlVIDql5T52H0N84vM0m32MOaMyWlI9HWDzh44BendiH82VjcEX/2Mlb/EF5 VKeFkvABe1xy40cDa5QYmyCCjjmkPNZRB6OCz7+yAT6wNGDk58kBCFNqGgrE4Nvv3ILM an7A== X-Gm-Message-State: AOJu0YxlSRy3wYNEO9dF5RxnGZq0ZZ15VckRNAtvxfNBS1kdJUimUPr6 WtIKVXogbHywP9nSBayV1lB3LyJ87FQgHBECJhXapHhLA6de7vAuw0Szscp99Bvd92On6xnzzpq s8mWWP4bHx82cGhA2Fut74o/7E8duV+qjiH9T6J55oN+BctPd5OxVaGUKfcP0ymyf7raJHMBPyr ngeLT7YzVGN2PW4jqBKt6eUh0rfQMVwpw6GhOcujjqWeY8OKYpSzV6XlCo X-Gm-Gg: AR+sD10V1VOeqpaw8tlDOp2potUnJOsyuZ18nJC63asRbd37+ebDqvalcRIZ6QgV8EF fnMH7KvGN+sdvLqZOwFzN05X+D2hioAJFU7GPvtkZ1w22kZFNGU8ul1bhmTN5bOo2N34UBl6w3s 838J6UbDskXKYBruwR16eQsu8q51Cs+nyFDOEux9St+43zk/bqCEYnAeorcbrzCwzr1kg9D3zPA 0oyvviuHyJPhOUlGapVyQ0cjy56zEYTKzO58y2uJjJ/6qxVGsmiTCCoIQezRGBFD5lJUKTsRveM 9PQVdYXG255DsT+KyOvceO2DbUmePHjq3sxQ+Hp982TxA4plTEqH0v4Vpxr/gcGWoZwe72GkUkh I3hCpm96whLg+sZq/u/a4k8mxf6puazixIa+0BgNU7zc//m76V01zhu4+53CkjxnOMxFBvgOAtV dkWWZ2ml7yc2V3YNL+uZUeirBIcVxsZ71oXQRX83nMQ94OBnC3oizlCqsEv0/MeQgXkS3afHK/Z lWN/AQin21qe6ii/lJHFz4QgeLJl94Ey9oV2Ban X-Received: by 2002:a05:600c:1c21:b0:493:e460:1f6 with SMTP id 5b1f17b1804b1-4994e6fe377mr201696135e9.0.1786028755892; Thu, 06 Aug 2026 08:05:55 -0700 (PDT) From: Aaron Carson To: pve-devel@lists.proxmox.com Subject: [PATCH acme] acme: fix USER_AGENT variable interpolation in curl calls Date: Thu, 6 Aug 2026 15:04:49 +0000 Message-ID: <20260806150448.3564005-2-aaron@aaroncarson.co.uk> X-Mailer: git-send-email 2.52.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy KAM_COUK 0.15 Scoring .co.uk emails higher due to poor registry security. RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: VRID5UBH3MTPAYCVRHKNRLD47JJWYDHX X-Message-ID-Hash: VRID5UBH3MTPAYCVRHKNRLD47JJWYDHX X-MailFrom: aaron@aaroncarson.co.uk X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Aaron Carson X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Signed-off-by: Aaron Carson --- Hi folks, just a small fix - noticed that the user agent being seen by my DNS server was literally USER_AGENT when updating DNS for ACME. I know the contribution guide says to discuss before sending in a patch - but for a two character fix, thought that was unnecessary. Apologies if not though. Thanks! src/proxmox-acme | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/proxmox-acme b/src/proxmox-acme index 705f7df..39c770b 100644 --- a/src/proxmox-acme +++ b/src/proxmox-acme @@ -348,9 +348,9 @@ _get_impl() { _CURL="$_CURL --connect-timeout $t" fi if [ "$onlyheader" ]; then - $_CURL -I --user-agent "USER_AGENT" -H "$_H1" -H "$_H2" -H "$_H3" -H "$_H4" -H "$_H5" "$url" + $_CURL -I --user-agent "$USER_AGENT" -H "$_H1" -H "$_H2" -H "$_H3" -H "$_H4" -H "$_H5" "$url" else - $_CURL --user-agent "USER_AGENT" -H "$_H1" -H "$_H2" -H "$_H3" -H "$_H4" -H "$_H5" "$url" + $_CURL --user-agent "$USER_AGENT" -H "$_H1" -H "$_H2" -H "$_H3" -H "$_H4" -H "$_H5" "$url" fi ret=$? if [ "$ret" != "0" ]; then -- 2.52.0