Re: [PATCH common/manager/proxmox-widget-toolkit/storage v2 00/17] GUI Support for Custom Storage Plugins

[Jakob Klocker <j.klocker@proxmox.com>]

On 7/17/26 5:50 PM, Max R. Carrara wrote:
> GUI Support for Custom Storage Plugins - v2
> ===========================================
> 
> Notable Changes Since v1
> ------------------------
> 
> - Fix the 'sensitive' keyword being stringified to `"1"` when enabled,
>   instead of being an integer.
>   (Thanks @Jakob!)
> 
> - Fix a non-breaking hyphen sneaking in, most likely caused by me
>   copying an already existing string from the UI or some other place.
>   (Thanks @Jakob!)
> 
> - Implement *experimental* support for `patternProperties` in order to
>   support the custom schema keywords `x-advanced` and `x-hidden`, which
>   helps to avoid hard-coding which fields are in the "Advanced" section
>   and which ones are hidden in the UI, respectively.
> 
>   Please note that the commits implementing this are explicitly marked
>   as RFC and can be dropped if `patternProperties` is undesired.
> 
>   I figured that this was a decent use case for `patternProperties`, but
>   I'm on the fence whether this is something that we actually want.
>   Feedback is very welcome in that regard.
> 
>   Note that the 'sensitive' keyword that's added to the returned plugin
>   schema is kept as is at the moment -- I'm a bit on the fence here too
>   whether it should be an 'x-' keyword or whether we should actually
>   include it in the default schema for JSON schemas overall, as I can
>   see it being useful in other places in the future too, e.g. the ACME
>   plugin code (for hiding API keys etc.).
> 
> 
> Also, given that the two fixes above are rather trivial and no
> functionality has been changed, I suggest keeping Jakob's trailer(s)
> from v1 in, should this series get applied.
> 
[snip]
Thanks for the v2!

I've tested the x-hidden and x-advanced properties by adding them to
the SSHFS plugin; both work as expected. The sensitive keyword now
displays correctly as an integer, and the reported non-breaking hyphen
is replaced with a normal dash.

I've left comments on the patches. Most are style-nits, but there's
one important thing to look into in 2/17.

I also noticed that the module-sorting nit I mentioned isn't applied
consistently across the codebase, so if it's not relevant here, feel
free to ignore it.

The text changes and the backend part look good to me. I'm not too
familiar with the frontend part of PVE yet, so I can't give much input
on that end.