[RFC pve-manager v2 17/17] ui: storage: use property extension keywords for UI hints

["Max R. Carrara" <m.carrara@proxmox.com>]

Use the newly added extension 'x-advanced' and 'x-hidden' extension
keywords for storage plugin property schemas to avoid hard-coding
whether a given field belongs in the "Advanced" section or is hidden,
respectively.

Signed-off-by: Max R. Carrara <m.carrara@proxmox.com>
---
NOTE: This patch is experimental and thus marked as RFC.

 www/manager6/storage/CustomEdit.js | 24 ++++++------------------
 1 file changed, 6 insertions(+), 18 deletions(-)

diff --git a/www/manager6/storage/CustomEdit.js b/www/manager6/storage/CustomEdit.js
index 45fda7c8..cca66ffb 100644
--- a/www/manager6/storage/CustomEdit.js
+++ b/www/manager6/storage/CustomEdit.js
@@ -145,27 +145,11 @@ Ext.define('PVE.storage.CustomInputPanel', {
             // --> must not be added here
             'enable',

-            // not exposed in the UI for any inbuilt storage types
-            // --> must not be added here (in order to remain consistent)
-            'bwlimit',
-            'content-dirs',
-            'create-base-path',
-            'create-subdirs',
-            'format',
-
             // handled separately for consistency
             'content',
             'shared',
         ]);

-        const advancedFields = new Set([
-            'preallocation',
-
-            // note that the technology preview hint is automatically added
-            // further below if a plugin uses this property
-            'snapshot-as-volume-chain',
-        ]);
-
         // Added first for consistency's sake
         for (const propertyName of ['content', 'shared']) {
             let property = schema[propertyName];
@@ -175,18 +159,22 @@ Ext.define('PVE.storage.CustomInputPanel', {
             }
         }

-        for (const propertyName of Object.keys(schema).sort()) {
+        for (const [propertyName, propertySchema] of Object.entries(schema).sort()) {
             if (reservedFields.has(propertyName)) {
                 continue;
             }

+            if (propertySchema['x-hidden']) {
+                continue;
+            }
+
             let fieldDef = me.buildFormFieldFromProperty(propertyName);

             if (fieldDef === undefined) {
                 continue;
             }

-            if (advancedFields.has(propertyName)) {
+            if (propertySchema['x-advanced']) {
                 me.addAdvancedWidget(fieldDef);
             } else {
                 me.addWidget(fieldDef);
--
2.47.3