Re: [PATCH common/manager/proxmox-widget-toolkit/storage v2 00/17] GUI Support for Custom Storage Plugins

[Ciro Iriarte <cyruspy@gmail.com>]

Hi Max,

Since I'm the one who asked for the advanced hint, I should say plainly
that x-advanced and x-hidden are worth keeping, in case the RFC marking
makes them look optional.

>From a third-party plugin author's side this is the difference between an
operator seeing a dozen fields with the four that matter buried among
them, and seeing four fields with a collapsible Advanced section. My
plugin carries management endpoint, credentials, pool, ldev_range,
host_group_prefix, control_plane, QoS limits and consistency-group
options; most deployments touch the endpoint, credentials and pool and
never look at the rest. Without a hint, every one of those is equally
prominent, and the hardcoded advanced list can't help since it only knows
about inbuilt properties.

On patternProperties as the mechanism I have no strong opinion -- that's
a JSONSchema.pm call and you're better placed to make it. A plain
allowlist of known x- keywords would serve me identically. My interest is
only in the capability surviving in some form.

On 'sensitive': I'd expect it in the default schema rather than as an x-
keyword. It describes a property of the data rather than a UI hint, and
the ACME case you mentioned suggests it'll have more than one consumer.

On testing: I'll validate against pve-FCLUPlugin once this lands in the
repo, rather than per-revision while it's still in review -- so expect
feedback from me after it's merged, not a Tested-by on v2.

Thanks,
Ciro